Use getexepath in mono to deduplicate related code #60449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
am11
force-pushed
the
feature/native/consolidations
branch
from
4673d69
to
d2ccc2d
Compare
am11
requested review from
lambdageek,
lateralusX,
marek-safar,
thaystg and
vargaz
as code owners
am11
commented
Oct 15, 2021
|
cc @jkotas |
lambdageek
reviewed
Oct 15, 2021
lambdageek
reviewed
Oct 15, 2021
lateralusX
approved these changes
Oct 18, 2021
akoeplinger
approved these changes
Oct 18, 2021
|
@lambdageek, if it looks good, can this be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel of #44999.
Windows and Wasm cases are new in
src/native/common/getexepath.hfor Mono.Also, the linkage specifier had to be
staticinstead ofextern; to avoid duplicate symbol errors. Previously we had only one C usage in libs.native, but since mono is calling this function from two places, linker was throwing duplicate symbol error (at the very end of build).Second commit is for trailing whitespace cleanup of modified files in the first one (my editor highlights those places quite noticeably, so I "fixed" it 🙂).