Move NoInt32OverflowInTheBufferingLogic to OuterLoop #60606
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsIt appears to be a long running test in CI: https://dev.azure.com/dnceng/public/_build/results?buildId=1424571&view=ms.vss-test-web.build-test-results-tab&runId=41213488&resultId=193806&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab In addition, this PR addresses some suggestions left in #60459.
|
ghost
locked as resolved and limited conversation to collaborators
|
/backport to release/6.0 |
|
FYI you need to unlock a locked issue otherwise the backport bot can't post comments on it. This is also failing on /backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1604538761 |
|
@akoeplinger backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Move NoInt32OverflowInTheBufferingLogic to OuterLoop and address pending feedback
Using index info to reconstruct a base tree...
M src/libraries/System.IO.FileSystem/tests/FileStream/Read.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.IO.FileSystem/tests/FileStream/Read.cs
CONFLICT (content): Merge conflict in src/libraries/System.IO.FileSystem/tests/FileStream/Read.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Move NoInt32OverflowInTheBufferingLogic to OuterLoop and address pending feedback
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@jozkee oh well, looks like this will need to be done manually anyway 😄 |
) * Move NoInt32OverflowInTheBufferingLogic to OuterLoop and address pending feedback (#60606) * Don't create multiple large files at the same time (#62519) * move existing large file tests into a separate type (no code changes) * don't run the large file tests in parallel * use FileOptions.DeleteOnClose to ensure that each test removes it's own file use single large file to test File.ReadAllBytes and ile.ReadAllBytesAsync for both limits * Fix DisableParallelization build issue * Apply suggestions from code review Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> * Update src/libraries/System.IO.FileSystem/tests/LargeFileTests.cs Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> * Notepad with uppercase (#62487) Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> Co-authored-by: Dan Moseley <danmose@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
It appears to be a long running test in CI: https://dev.azure.com/dnceng/public/_build/results?buildId=1424571&view=ms.vss-test-web.build-test-results-tab&runId=41213488&resultId=193806&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab
In addition, this PR addresses some suggestions left in #60459.