-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seed the unified System.Security.Cryptography.dll #61025
Conversation
* All of System.Security.Cryptography.Primitives has been moved * AsymmericKeyExchangeFormatter moved from S.S.C.Algorithms * Most of the references to S.S.C.Primitives were adjusted by a script, too many moles to whack by hand.
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue Details
|
The "allConfigurations" build finally succeeded, so this should be in a usefully reviewable state now. |
...oft.Extensions.FileProviders.Physical/src/Microsoft.Extensions.FileProviders.Physical.csproj
Outdated
Show resolved
Hide resolved
@bartonjs first, awesome. Glad this is happening. Do you have an idea on how much, if any, and when, you might continue to do the consolidation of the S.S.Cryptography libraries? I'll need to re-shuffle a number of my in-flight branches (not complaining) and would prefer to hold off on that until you think the consolidation is mostly complete. |
All of
Once this goes through, it'll probably be library-by-library. Encodings, then Algorithms, then probably all the platformmy ones at once, then X509. If things get tricky then maybe split across more PRs. ("If swimmingly, then fewer"... but I don't see that happening) The idea is to go quickly so that things like "what'd we change in net7" are easier to answer 😄. |
Contributes to #55690.