-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completely lock-free ClassLoader::LookupTypeKey #61346
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1b003e3
embedded size
VSadov 5330325
next array
VSadov c5db8c4
read consistency while rehashing
VSadov c264f69
comments
VSadov e8e7d6e
remove CRST_UNSAFE_ANYMODE and COOP mode in the callers
VSadov b9b4813
typo
VSadov 749695a
fix 32bit builds
VSadov 5569c66
couple changes from review.
VSadov 7c3cd08
Walk the buckets in resize.
VSadov f8b1021
remove a `REVIEW:` comment.
VSadov 067cefb
Update src/coreclr/vm/dacenumerablehash.inl
VSadov 1516f6b
remove use of `auto`
VSadov efe6043
DAC stuff
VSadov f455581
Constructor and GrowTable are not called by DAC, no need for DPTR, ad…
VSadov e874b3c
SKIP_SPECIAL_SLOTS
VSadov c7eb7e7
More compact dac_cast in GetNext
VSadov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoyosjs - is this correct or from TADDR it must be another dac_cast ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand this right
buckets[SLOT_NEXT]
is pointing to a new hash table that's an array of linked lists? Then it'sreturn dac_cast<DPTR(PTR_VolatileEntry)>(dac_cast<TADDR>(buckets[SLOT_NEXT]));
which can be simplified to
return dac_cast<DPTR(PTR_VolatileEntry)>(buckets[SLOT_NEXT]);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The
buckets[SLOT_NEXT]
will be pointing to the next larger table, if resize happened while you are doing a lookup. It will be rare. It is possible, even though extremely rare to see more than one new version.Every new one is 2x larger than previous, so there can't be too many even in the ultimate worst case.