Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop refactoring and commenting improvements #61496

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

BruceForstall
Copy link
Member

@BruceForstall BruceForstall commented Nov 12, 2021

  • Remove unneeded FIRST concept in loop table; it was always equal to TOP.
  • Rename optMarkLoopsBlocks to optScaleLoopBlocks to more accurately describe
    what it does. More consistently report block scaling in the dump
  • Create optMarkLoopHeads. This was refactored out of fgRemoveUnreachableBlocks so
    it can be called in a more logical location (at the beginning of optFindLoops),
    and only does one thing.
  • fgMakeOutgoingStructArgCopy: remove unused argIndex argument; reorder calls to
    fgMightHaveLoop.
  • Update and write a bunch of comments; convert away from /* */ style comments.

No asm diffs

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 12, 2021
@ghost
Copy link

ghost commented Nov 12, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Remove unneeded FIRST concept in loop table; it was always equal to TOP.
  • Rename optMarkLoopsBlocks to optScaleLoopBlocks to more accurately describe
    what it does. More consistently report block scaling in the dump
  • Create optMarkLoopHeads. This was refactored out of fgRemoveUnreachableBlocks so
    it can be called in a more logical location (at the beginning of optFindLoops),
    and only does one thing.
  • fgMakeOutgoingStructArgCopy: remove unused argIndex argument; reorder calls to
    fgMightHaveLoop.
  • Update and write a bunch of comments; convert away from /* */ style comments.
Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Member Author

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

- Remove unneeded FIRST concept in loop table; it was always equal to TOP.
- Rename optMarkLoopsBlocks to optScaleLoopBlocks to more accurately describe
what it does. More consistently report block scaling in the dump
- Create optMarkLoopHeads. This was refactored out of fgRemoveUnreachableBlocks so
it can be called in a more logical location (at the beginning of optFindLoops),
and only does one thing.
- fgMakeOutgoingStructArgCopy: remove unused `argIndex` argument; reorder calls to
fgMightHaveLoop.
- Update and write a bunch of comments; convert away from `/* */` style comments.
@BruceForstall
Copy link
Member Author

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
Copy link
Member Author

@AndyAyersMS @dotnet/jit-contrib PTAL

Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants