-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync shared code from aspnetcore #62069
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943
|
Synced changes from fixing dotnet/aspnetcore#38604 This code is related to writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No reaction is needed for tests AFAIK, because tests (for some unknown reason) use separate simplified encoders for both HPACK and QPACK -- and they don't touch files from the shared folder -- maybe that should be changed in the future.
This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943