Convert System.DirectoryServices.Protocols and System.Drawing.Common to use GeneratedDllImport #62365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use GeneratedDllImport Convert the last two remaining libraries to use GeneratedDllImport based on our current support. This means that any P/Invokes that don't use HandleRef, layout classes, non-blittable structs, or non-blittable types defined in other assemblies have been converted. For HandleRef support, we're looking at adding the support through our standard "custom type marshalling" design that we will use for non-blittable structs and layout classes, but that still requires that support to be available/used.
jkoritzinsky
requested review from
stephentoub,
AaronRobinsonMSFT and
elinor-fung
AaronRobinsonMSFT
approved these changes
Dec 4, 2021
src/libraries/Common/src/Interop/Windows/Gdi32/Interop.BitBlt.cs
Outdated
Show resolved
Hide resolved
… entrypoint name isn't decorated with an A/W suffix
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the last two remaining libraries to use GeneratedDllImport based on our current support.
This means that any P/Invokes that don't use HandleRef, layout classes, non-blittable structs, or non-blittable types defined in other assemblies have been converted.
For HandleRef support, we're looking at adding the support through our standard "custom type marshalling" design that we will use for non-blittable structs and layout classes, but that still requires that support to be available/used, which depends at least partially on API Review.