Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip source gen DLLs in mono AOT #62518

Merged
merged 5 commits into from
Dec 9, 2021
Merged

Conversation

agocke
Copy link
Member

@agocke agocke commented Dec 8, 2021

These appear to be failing because Microsoft.CodeAnalysis isn't present, but that's expected
behavior for source generators/analyzers, as they are plugins.

Fixes #62372

These appear to be failing because Microsoft.CodeAnalysis isn't present, but that's expected
behavior for source generators/analyzers, as they are plugins.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@agocke
Copy link
Member Author

agocke commented Dec 8, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agocke agocke marked this pull request as ready for review December 9, 2021 06:50
@agocke agocke requested a review from a team December 9, 2021 06:50
@agocke
Copy link
Member Author

agocke commented Dec 9, 2021

@jkoritzinsky I think this fixes #62372

@ghost
Copy link

ghost commented Dec 9, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

These appear to be failing because Microsoft.CodeAnalysis isn't present, but that's expected
behavior for source generators/analyzers, as they are plugins.

Author: agocke
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@akoeplinger akoeplinger merged commit 6f46a09 into dotnet:main Dec 9, 2021
@akoeplinger
Copy link
Member

Thank you!

@agocke agocke deleted the skip-src-gen-dlls branch December 9, 2021 18:42
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DllImportGenerator is failing in Mono llvmfullAOT
3 participants