Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedup addprefix & delete unused defines from cmake #62528

Merged
merged 3 commits into from
Dec 11, 2021
Merged

Dedup addprefix & delete unused defines from cmake #62528

merged 3 commits into from
Dec 11, 2021

Conversation

am11
Copy link
Member

@am11 am11 commented Dec 8, 2021

Commits:

  1. Dedup addprefix cmake function and delete unused defailes like PACKAGE_*, which are autoconf artifacts, unused in current cmake based setup.
  2. Change #if FALSE to #if 0 in C files.
  3. Cleanup trailing whitepaces in files from 1 and 2.

@am11
Dedup addprefix & delete unused defines from cmake
bec6a83
@am11
Change if FALSE to if 0 in C files
9944ba1
@am11
Cleanup trailing whitespace in changeset files
ab9b081 
```sh
# git remote add dotnet https://github.com/dotnet/runtime && git pull --rebase dotnet main

if uname 2>/devnull | grep -q Darwin; then
    space=" "
fi

git show --name-only --pretty="" HEAD...dotnet/main |\
    xargs -I{} sh -c "test -f {} && sed -i$space'' 's/[[:space:]]*$//' {}"
```
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 8, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Dec 8, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Commits:

  1. Dedup addprefix cmake function and delete unused defailes like PACKAGE_*, which are autoconf artifacts, unused in current cmake based setup.
  2. Change #if FALSE to #if 0 in C files.
  3. Cleanup trailing whitepaces in files from 1 and 2.
Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution
Milestone: -

@vargaz
Copy link
Contributor

vargaz commented Dec 8, 2021

The mono changes look ok

@am11
Copy link
Member Author

am11 commented Dec 11, 2021

@lambdageek, is it good to merge? Is so please do, I don't have write access.

@marek-safar marek-safar merged commit 20f994c into dotnet:main Dec 11, 2021
@am11 am11 deleted the feature/native-configs branch December 12, 2021 08:43
@am11
Copy link
Member Author

am11 commented Dec 12, 2021

Thanks, I wanted to use addprefix() in #62673. :)

@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@imhameed imhameed Awaiting requested review from imhameed

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@vargaz vargaz Awaiting requested review from vargaz

Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@am11 @vargaz @lambdageek @marek-safar