Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the namespaces of HashProviderDispenser #62590

Merged

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Dec 9, 2021

I was spiking out an idea and noticed that some of the hash provider dispensers were still in Internal.Cryptography. This moves them to all be in System.Security.Cryptography.

Browser and OpenSsl were the outliers. Windows and Apple were already moved.

Being in separate namespaces made it impossible to create a managed partial that all platforms could use.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 9, 2021
@ghost
Copy link

ghost commented Dec 9, 2021

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

I was spiking out an idea and noticed that some of the hash provider dispensers were still in Internal.Cryptography. This moves them to all be in System.Security.Cryptography.

Browser and OpenSsl were the outliers. Windows and Apple were already moved.

Being in separate namespaces made it impossible to create a managed partial that all platforms could use.

Author: vcsjones
Assignees: -
Labels:

area-System.Security, community-contribution

Milestone: -

@jkotas
Copy link
Member

jkotas commented Dec 10, 2021

Opened #62613 on the System.Net.Quic tests crash

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@danmoseley danmoseley merged commit 8d8ebca into dotnet:main Dec 12, 2021
@vcsjones vcsjones deleted the fix-hash-provider-dispenser-namespaces branch December 15, 2021 16:48
@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants