Mark forward delegate stubs as not having hidden arguments #62617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward delegate interop stubs do not use hidden argument. The hidden argument passed to them is a random value that can lead to crash during stackwalking. Fixes dotnet#62613
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsForward delegate interop stubs do not use hidden argument. The hidden argument passed to them is a random value that can lead to crash during stackwalking. Fixes #62613
|
|
The crash was introduced as side-effect of #62271. The random hidden arg value was overwritten by a bogus, but predictable value, that was avoiding the crash with a lot of luck. |
jkoritzinsky
approved these changes
Dec 10, 2021
|
@maryamariyan mislabeling here was remarkable. Btw is it time for another retraining? |
|
The bot labelled it based on the linked issue. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward delegate interop stubs do not use hidden argument. The hidden argument passed to them is a random value that can lead to crash during stackwalking.
Fixes #62613