RPM package needs to create host symlink #62925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
added
Servicing-consider
jkoritzinsky
approved these changes
Dec 16, 2021
|
Approved on tactics and over email. |
NikolaMilosavljevic
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62455
Customer impact
Fixes: #61849
Symlink, installed using scripts, is not owned by the package, which causes issues with upgrades from 3.1 or 5.0, where symlink will get removed from disk. (RPM installation is done in "install-new then uninstall-old" fashion.)
This PR restores the functionality that was in place for 3.1 and 5.0 releases, where symlink is created during build and installed with RPM package. Consequently, any file installed with package is owned by it, which ensures proper install, upgrade and uninstall behavior.
Dependent Arcade change was merged with: dotnet/arcade#8251 and is usable in dotnet/runtime (runtime/6.0 branch) after: #62799
Testing
Built host RPM package and tested install and upgrade scenarios.
Risk
Low. This is already present in 7.0 and has been in 3.1 and 5.0. With this change 6.0 will utilize the same model for creation of dotnet symlink.