Enable IDE0059 analyzer: Unnecessary assignment of a value #63340

marek-safar · 2022-01-04T14:57:18Z

No description provided.

ghost · 2022-01-04T14:57:33Z

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	marek-safar
Assignees:	marek-safar
Labels:	`area-Meta`
Milestone:	-

...n/Runtime/Assemblies/NativeFormat/NativeFormatRuntimeAssembly.GetTypeCore.CaseInsensitive.cs

...Reflection.Core/src/System/Reflection/Runtime/CustomAttributes/RuntimeCustomAttributeData.cs

...ate.Reflection.Core/src/System/Reflection/Runtime/MethodInfos/RuntimePlainConstructorInfo.cs

src/coreclr/nativeaot/System.Private.TypeLoader/src/Internal/Runtime/TypeLoader/TypeBuilder.cs

...Private.TypeLoader/src/Internal/Runtime/TypeLoader/TypeLoaderEnvironment.SignatureParsing.cs

src/coreclr/tools/Common/Internal/Metadata/NativeFormat/Generator/ReaderGen.cs

src/libraries/Microsoft.Extensions.Caching.Memory/src/MemoryCache.cs

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs

src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionStringBuilder.cs

src/libraries/System.Data.Common/src/System/Data/ConstraintCollection.cs

src/libraries/System.Data.Common/src/System/Data/DataColumnCollection.cs

src/libraries/System.Data.Common/src/System/Data/DataRelationCollection.cs

src/libraries/System.Data.Common/src/System/Data/ForeignKeyConstraint.cs

src/libraries/System.Data.Odbc/.editorconfig

...em.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/common/BerConverter.cs

src/libraries/System.DirectoryServices/.editorconfig

src/libraries/System.Net.Http/src/System/Net/Http/Headers/EntityTagHeaderValue.cs

...Private.DataContractSerialization/src/System/Runtime/Serialization/CollectionDataContract.cs

...stem.Private.DataContractSerialization/src/System/Runtime/Serialization/HybridObjectCache.cs

src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlBaseWriter.cs

src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs

src/libraries/System.Private.Xml/src/System/Xml/Xsl/IlGen/XmlILOptimizerVisitor.cs

...Private.TypeLoader/src/Internal/Runtime/TypeLoader/TypeLoaderEnvironment.SignatureParsing.cs

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs

src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionFactory.cs

...em.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/common/BerConverter.cs

stephentoub · 2022-01-11T17:32:56Z

src/libraries/System.Net.Http/src/System/Net/Http/Headers/ViaHeaderValue.cs

@@ -281,7 +281,7 @@ private static void CheckReceivedBy(string receivedBy)

            // 'receivedBy' can either be a host or a token. Since a token is a valid host, we only verify if the value
            // is a valid host.;
-            if (HttpRuleParser.GetHostLength(receivedBy, 0, true, out string? host) != receivedBy.Length)
+            if (HttpRuleParser.GetHostLength(receivedBy, 0, true, out _) != receivedBy.Length)


@geoffkizer, not sure how much it actually matters, but looking at the call sites to GetHostLength, it seems several of them end up ignoring the out string host even though the method will end up allocating one, regardless. Might be worth a look, and if there are other similar cases that could be improved.

Yeah, this is ugly. The usual pattern of the GetXLength methods here and elsewhere is that they return an int to indicate the length, but don't actually construct the substring, which the caller can do trivially. Not sure why this one is different. I'll take a look.

Fixed in #63641
See also #63640

stephentoub · 2022-01-11T17:34:47Z

...Net.NetworkInformation/src/System/Net/NetworkInformation/NetworkAddressChange.UnknownUnix.cs

@@ -9,15 +9,6 @@ namespace System.Net.NetworkInformation
 {
    public partial class NetworkChange
    {
-        static NetworkChange()
-        {
-            // fake usage of static readonly fields to avoid getting CA1823 warning when we are compiling this partial.


Is this not accurate?

It was but I changed csproj file not to pull these private fields at all

marek-safar · 2022-01-12T17:10:35Z

Failures are unrelated due to OSError: [Errno 28] No space left on device

ghost assigned marek-safar Jan 4, 2022

dotnet-issue-labeler bot added the area-Meta label Jan 4, 2022