-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#51371 fixed failing test in iossimulator #63877
Merged
mkhamoyan
merged 18 commits into
dotnet:main
from
mkhamoyan:51371_failing_filesystem_tests
Jan 27, 2022
Merged
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c9e82e3
#51371 fixed failing test in iossimulator
mkhamoyan 0428831
#51371 added skiptestexception
mkhamoyan cfe4592
#51371 added space after reference
mkhamoyan 4b8fe65
#51371 fixed remaining failing tests
mkhamoyan 7a3053c
#51371 whitespace issue
mkhamoyan 5e2771d
#51371 removed extra spaces
mkhamoyan 4b2dfb1
Squashed commit of the following:
mkhamoyan 69ea51e
#51371 added pipeName case for running on macos
mkhamoyan 65daf2f
Merge branch 'main' into 51371_failing_filesystem_tests
mkhamoyan 8696973
#51371 removed extra spaces, adjusted IsCaseSensitiveProperty and oth…
mkhamoyan 100cac7
Merge branch '51371_failing_filesystem_tests' of https://github.com/m…
mkhamoyan 507d239
#51371 removed extra spaces
mkhamoyan 6154087
#51371 removed pipePath change in windows file
mkhamoyan d989e86
#51371 Done minor changes
mkhamoyan d457075
#51371 extended maxdirectory for not windows
mkhamoyan bdc06e9
#51371 in case of windows don't change parameter IsCaseSensitiveOS
mkhamoyan eddd2ca
#51371 changing maxdirectory for nonwindows
mkhamoyan 2501ef2
#51371 removed from Pipestream the change and edited path in FileClea…
mkhamoyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,9 @@ | |
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Linq; | ||
using System.Runtime.InteropServices; | ||
using Xunit; | ||
using Microsoft.DotNet.XUnitExtensions; | ||
|
||
namespace System.IO.Tests | ||
{ | ||
|
@@ -217,11 +219,16 @@ public void LongFileName() | |
Assert.False(File.Exists(path)); | ||
} | ||
|
||
[Fact] | ||
[ConditionalFact] | ||
[PlatformSpecific(CaseSensitivePlatforms)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it make more sense to expand upon There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Expanded IsCaseSensitiveOS. |
||
[ActiveIssue("https://github.com/dotnet/runtime/issues/51371", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)] | ||
mkhamoyan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public void CaseSensitive() | ||
{ | ||
if (RuntimeInformation.RuntimeIdentifier.StartsWith("iossimulator") | ||
|| RuntimeInformation.RuntimeIdentifier.StartsWith("tvossimulator")) | ||
{ | ||
throw new SkipTestException("iOS/tvOS simulators run on a macOS host and are subject to the same case sensitivity behavior."); | ||
} | ||
|
||
DirectoryInfo testDir = Directory.CreateDirectory(GetTestFilePath()); | ||
string testFile = Path.Combine(testDir.FullName, GetTestFileName()); | ||
using (File.Create(testFile + "AAAA")) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a property to https://github.com/dotnet/runtime/blob/main/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs and use it in the condition instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea.