Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic Enum methods where possible. #64850

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

teo-tsirpanis
Copy link
Contributor

This PR updates all non-test projects that exclusively target .NET 6 and above to use the generic Enum methods (#2364), reducing boxing and (perhaps?) making the code more AOT-friendly.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 5, 2022
@ghost
Copy link

ghost commented Feb 5, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR updates all non-test projects that exclusively target .NET 6 and above to use the generic Enum methods (#2364), reducing boxing and (perhaps?) making the code more AOT-friendly.

Author: teo-tsirpanis
Assignees: -
Labels:

area-Meta

Milestone: -

…omponentModel/ToolboxItemFilterAttribute.cs

Co-authored-by: Günther Foidl <gue@korporal.at>
@jeffhandley jeffhandley self-assigned this Feb 6, 2022
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub reopened this Feb 28, 2022
@stephentoub stephentoub closed this Mar 1, 2022
@stephentoub stephentoub reopened this Mar 1, 2022
@stephentoub
Copy link
Member

@steveisok, the runtime-staging legs keep timing out on this PR. Is there a known issue here? Is it possible this PR is causing it?

@steveisok
Copy link
Member

I'd update the branch to the latest main. The helix queue being used is different.

@stephentoub
Copy link
Member

stephentoub commented Mar 2, 2022

I'd update the branch to the latest main. The helix queue being used is different.

Thanks.

Shouldn't that have happened automatically when I closed and re-opened the PR? Or does rebasing on the latest main no longer happen automatically?

Given that these are stale and everything else passed and there's nothing in the PR that should be mono-specific or iOS-specific, I'm just going to merge.

@stephentoub stephentoub merged commit d579527 into dotnet:main Mar 2, 2022
@teo-tsirpanis teo-tsirpanis deleted the generic-enum-methods branch March 2, 2022 16:29
@teo-tsirpanis
Copy link
Contributor Author

That was why you closed and reopened it twice. 😅 Didn't know that was ever a thing.

@danmoseley
Copy link
Member

@teo-tsirpanis it's easier than pushing a blank change -- I even do it on my phone! The other option is an /azp command, but that requires committer access plus it's harder to remember.

@teo-tsirpanis
Copy link
Contributor Author

When Stephen said about "rebasing on the latest main" my first thought was that it would rebase my fork's branch and was confused, but turns out he meant it would run CI again with my changes incorporated to the latest main, and makes more sense.

@danmoseley
Copy link
Member

Got it, yes, I believe each time that validation runs, it behind the scenes rebases on the latest HEAD before it builds.

@teo-tsirpanis teo-tsirpanis changed the title Use generic Enum methods when possible. Use generic Enum methods where possible. Mar 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants