Remove ExactSpelling from GeneratedDllImport #65343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… previously probed entry-point suffix when ExactSpelling is false.
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThe new behavior will be equivalent to This PR also updates the "convert to GeneratedDllImport" code fix provider to provide code fixes that include the suffixes for the entry-points that were previously checked by the Opening as a draft now as I had to update the runtime P/Invokes to not rely on
|
jkoritzinsky
added
the
source-generator
…n ExactSpelling = false to use explicit entrypoint names.
jkoritzinsky
force-pushed
the
exactspelling_remove
branch
from
59a533d
to
a3f9c67
Compare
jkoritzinsky
force-pushed
the
exactspelling_remove
branch
from
90ef425
to
136adae
Compare
|
All of the errors here are due to Helix instability, so this is ready for review. |
AaronRobinsonMSFT
approved these changes
Feb 18, 2022
...Runtime.InteropServices/gen/DllImportGenerator/Analyzers/ConvertToGeneratedDllImportFixer.cs
Show resolved
Hide resolved
elinor-fung
approved these changes
Feb 19, 2022
Co-authored-by: Elinor Fung <elfung@microsoft.com>
5 tasks
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new behavior will be equivalent to
ExactSpelling=true.This PR also updates the "convert to GeneratedDllImport" code fix provider to provide code fixes that include the suffixes for the entry-points that were previously checked by the
DllImportimplementation in the runtime, so the user can select which one they were using previously (unsuffixed or suffixed).Opening as a draft now as I had to update the runtime P/Invokes to not rely on
ExactSpelling=falsebehavior and I want to make sure I didn't miss anything.