Fix slngen.proj and update solution files #65711
Conversation
The SolutionName property is defined by the SDK and hence the condition was always true. Also the star (*) didn't expand when using the ValurOrDefault msbuild function. Fixing this by using a different name `SolutionNameOverride` and avoiding the ValueOrDefault msbuild function.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsThe SolutionName property is defined by the SDK and hence the condition was always true. Also the star (*) didn't expand when using the ValurOrDefault msbuild function. Fixing this by using a different name Tested the change locally. Last time I didn't notice the issue because I only tested the changes with passing in a solution name.
|
|
@akoeplinger just noticed that the solution files are out-of-date. Will push another commit in a few minutes. |
ViktorHofer
changed the title
Updating the solution files as those changed because of microsoft/slngen@cb57e28 and apparently the solution files never were updated.
|
The second commit now contains the updated solution files. |
|
Merging as the changes aren't exercised in CI at all. |
|
@eerhardt the issue that originally reported regarding projects with the same assembly name but different project names clashing inside solution generated with slngen was long fixed but we never updated the solution files in this repo. That is now done with this PR :) |
ghost
locked as resolved and limited conversation to collaborators
The SolutionName property is defined by the SDK and hence the condition was always true. Also the star (*) didn't expand when using the ValurOrDefault msbuild function. Fixing this by using a different name
SolutionNameOverrideand avoiding the ValueOrDefault msbuild function.Tested the change locally. Last time I didn't notice the issue because I only tested the changes with passing in a solution name.
Also updating the solution files in the second commit. Those changed because of microsoft/slngen@cb57e28 but apparently the solution files never got updated with the updated version.