Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DivRem intrinsic for X86 #66551

Merged
merged 85 commits into from
Feb 15, 2023
Merged

Implement DivRem intrinsic for X86 #66551

merged 85 commits into from
Feb 15, 2023

Commits on Mar 7, 2022

  1. Add managed api for divrem

    @huoyaoyuan
    huoyaoyuan committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    00da1f4 View commit details
    Browse the repository at this point in the history

  2. Add NI definition of DivRem

    @huoyaoyuan
    huoyaoyuan committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    d679cca View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Fix DivRem to be static

    @huoyaoyuan
    huoyaoyuan committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    4eba5c5 View commit details
    Browse the repository at this point in the history

  2. Implement DivRem in clrjit

    @huoyaoyuan
    huoyaoyuan committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    6f8fbbf View commit details
    Browse the repository at this point in the history

  3. Add tests for DivRem

    @huoyaoyuan
    huoyaoyuan committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    997d8a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2022

  1. Adjust lsra and RMW

    @huoyaoyuan
    huoyaoyuan committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    c0c3dd6 View commit details
    Browse the repository at this point in the history

  2. Use DivRem intrinsic in Math

    @huoyaoyuan
    huoyaoyuan committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    c08cee7 View commit details
    Browse the repository at this point in the history

  3. Bring lower change from coreclr#37928 

    This fixes error while crossgen2 compiling Utf8Formatter.TryFormat(TimeSpan).
    @huoyaoyuan
    huoyaoyuan committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    1804350 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2022

  1. Fix signedness of DIV

    @huoyaoyuan
    huoyaoyuan committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    46c3f78 View commit details
    Browse the repository at this point in the history

  2. Revert RMW change and fix reg allocation

    @huoyaoyuan
    huoyaoyuan committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    2dbd2e9 View commit details
    Browse the repository at this point in the history

  3. Fix import of X64 intrinsic

    @huoyaoyuan
    huoyaoyuan committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    1b6d09b View commit details
    Browse the repository at this point in the history

  4. Fix static in PNSE version

    @huoyaoyuan
    huoyaoyuan committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    3ef3600 View commit details
    Browse the repository at this point in the history

  5. Fix accidential indent change

    @huoyaoyuan
    huoyaoyuan committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    acaf211 View commit details
    Browse the repository at this point in the history

  6. Apply format patch

    @huoyaoyuan
    huoyaoyuan committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    728440d View commit details
    Browse the repository at this point in the history

  7. op3 candidate should be different from op1 and op2

    @huoyaoyuan
    huoyaoyuan committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    4eace5d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Add guard over AsHWIntrinsic

    @huoyaoyuan
    huoyaoyuan committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    3182ed8 View commit details
    Browse the repository at this point in the history

  2. Disable DivRem intrinsic use for Mono

    @huoyaoyuan
    huoyaoyuan committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    48c12a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Fix LSRA and invalid assertion

    @huoyaoyuan
    huoyaoyuan committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    be5b33c View commit details
    Browse the repository at this point in the history

  2. Set RWM information correctly, although totally unused.

    @huoyaoyuan
    huoyaoyuan committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    d868194 View commit details
    Browse the repository at this point in the history

  3. Move multi-reg temp allocation to common helper

    @huoyaoyuan
    huoyaoyuan committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    ff65608 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Disable DivRem intrinsic test for Mono.

    @huoyaoyuan
    huoyaoyuan committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    b31f896 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Fix typo of quotient

    @huoyaoyuan
    huoyaoyuan committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    0bd1327 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Merge branch 'main'

    @huoyaoyuan
    huoyaoyuan committed May 20, 2022
    Configuration menu
    Copy the full SHA
    51959c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Merge branch 'main' into divrem

    @huoyaoyuan
    huoyaoyuan committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    8f1d9a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Merge branch 'main'

    @huoyaoyuan
    huoyaoyuan committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    f4aece2 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2022

  1. Merge branch 'main' into divrem

    @huoyaoyuan
    huoyaoyuan committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    75dda8d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Use impAssignMultiRegTypeToVar

    @huoyaoyuan
    huoyaoyuan committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    43049a9 View commit details
    Browse the repository at this point in the history

  2. Update #ifdef

    @huoyaoyuan
    huoyaoyuan committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    d485b61 View commit details
    Browse the repository at this point in the history

  3. Remove change in LowerBlockStore

    @huoyaoyuan
    huoyaoyuan committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    aeb114a View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Adjust assert and helper method

    @huoyaoyuan
    huoyaoyuan committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    aa57f26 View commit details
    Browse the repository at this point in the history

  2. Update CheckMultiRegLclVar

    @huoyaoyuan
    huoyaoyuan committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    9345e57 View commit details
    Browse the repository at this point in the history

  3. fix build errors

    @kunalspathak
    kunalspathak committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    65c0af6 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. Merge branch 'main' into divrem

    @huoyaoyuan
    huoyaoyuan committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    2bfa332 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge remote-tracking branch 'origin/main' into pr-66551

    @kunalspathak
    kunalspathak committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    7b41fd6 View commit details
    Browse the repository at this point in the history

  2. Fix some merge conflicts

    @kunalspathak
    kunalspathak committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    df922de View commit details
    Browse the repository at this point in the history

  3. Fix some errors

    @kunalspathak
    kunalspathak committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    924fc42 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Fix GCC build error

    @kunalspathak
    kunalspathak committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    1e7ff05 View commit details
    Browse the repository at this point in the history

  2. jit format

    @kunalspathak
    kunalspathak committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    62e6c59 View commit details
    Browse the repository at this point in the history

  3. Make the size depending on the struct

    @kunalspathak
    kunalspathak committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    a1b4802 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge remote-tracking branch 'origin/main' into divrem

    @kunalspathak
    kunalspathak committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    d547337 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Fix the formatting of summary

    @kunalspathak
    kunalspathak committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    8199acb View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Remove trailing spaces

    @kunalspathak
    kunalspathak committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    ed12edb View commit details
    Browse the repository at this point in the history

  2. Fix the tests to adopt new model

    @kunalspathak
    kunalspathak committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    532a8fd View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Fix MAX_RET_REG_COUNT -> MAX_MULTIREG_COUNT

    @kunalspathak
    kunalspathak committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    281c1b0 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Exclude from mono run

    @kunalspathak
    kunalspathak committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    97630a2 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Add RequiresProcessIsolation

    @kunalspathak
    kunalspathak committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    491f82e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. Merge remote-tracking branch 'origin/main' into divrem

    @kunalspathak
    kunalspathak committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    7487dfc View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Merge remote-tracking branch 'origin/main' into divrem

    @kunalspathak
    kunalspathak committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    7a862b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. Real fix for build break

    @kunalspathak
    kunalspathak committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    0fc11c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Fix the test cases to adopt to the new system

    @kunalspathak
    kunalspathak committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    8ab6023 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Disable for llvm-fullaot

    @kunalspathak
    kunalspathak committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    8d67890 View commit details
    Browse the repository at this point in the history

  2. Also continue disabling for mono

    @kunalspathak
    kunalspathak committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    0d85848 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into divrem

    @kunalspathak
    kunalspathak committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    1fd2b74 View commit details
    Browse the repository at this point in the history

  4. Disable the test in a different group

    @kunalspathak
    kunalspathak committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    18c9787 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Merge remote-tracking branch 'origin/main' into divrem

    @kunalspathak
    kunalspathak committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    b63dea3 View commit details
    Browse the repository at this point in the history

  2. fix merge conflict

    @kunalspathak
    kunalspathak committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    1b0e670 View commit details
    Browse the repository at this point in the history

  3. format

    @kunalspathak
    kunalspathak committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    7631033 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. fix another merge conflict error

    @kunalspathak
    kunalspathak committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    c0be00a View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Merge remote-tracking branch 'origin/main' into divrem

    @kunalspathak
    kunalspathak committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    83192b1 View commit details
    Browse the repository at this point in the history

  2. misc changes from review

    @kunalspathak
    kunalspathak committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    b29e1b4 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. fix the replay errors

    @kunalspathak
    kunalspathak committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    82c38a3 View commit details
    Browse the repository at this point in the history

  2. jit format

    @kunalspathak
    kunalspathak committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    61fabe2 View commit details
    Browse the repository at this point in the history

  3. Add exclude list in mono/llvmfullaot

    @kunalspathak
    kunalspathak committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    eea804c View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Review feedback and fix bug in CheckMultiRegLclVar

    @kunalspathak
    kunalspathak committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    ebe8781 View commit details
    Browse the repository at this point in the history

  2. Pass registerCount

    @kunalspathak
    kunalspathak committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    9dc8522 View commit details
    Browse the repository at this point in the history

  3. review feedback

    @kunalspathak
    kunalspathak committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    0093b79 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Remove the extra comments

    @kunalspathak
    kunalspathak committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    8260134 View commit details
    Browse the repository at this point in the history

  2. Disable tests on mono llvmfullaot runs as well

    @akoeplinger
    akoeplinger committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    320270a View commit details
    Browse the repository at this point in the history

  3. Add missing case for upper save/restore

    @kunalspathak
    kunalspathak committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a98dbde View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Add missing RequiresProcessIsolation

    @kunalspathak
    kunalspathak committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    06f0460 View commit details
    Browse the repository at this point in the history

  2. Revert "Add missing case for upper save/restore" 

    This reverts commit a98dbde.
    @kunalspathak
    kunalspathak committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1b3e851 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'huoyaoyuan/divrem' into divrem

    @kunalspathak
    kunalspathak committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9f192ac View commit details
    Browse the repository at this point in the history

  4. Remove RequiresProcessIsolation property

    @kunalspathak
    kunalspathak committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    537f678 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Merge branch 'main' into divrem

    @kunalspathak
    kunalspathak committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ca32b24 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Replace ref with fakelibs

    @kunalspathak
    kunalspathak committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e1b5fb3 View commit details
    Browse the repository at this point in the history

  2. Add references of fakelib to test project

    @kunalspathak
    kunalspathak committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    6589700 View commit details
    Browse the repository at this point in the history

  3. Fix CompatibilitySuppressions.xml

    @kunalspathak
    kunalspathak committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2a90b4b View commit details
    Browse the repository at this point in the history

  4. fix test builds

    @kunalspathak
    kunalspathak committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    aad300a View commit details
    Browse the repository at this point in the history

  5. Remove unneeded extern/using

    @kunalspathak
    kunalspathak committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    eb3272c View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Revert "Replace ref with fakelibs" 

    This reverts commit e1b5fb3.
    @kunalspathak
    kunalspathak committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    39ae98d View commit details
    Browse the repository at this point in the history

  2. Revert "Revert "Replace ref with fakelibs"" 

    This reverts commit 39ae98d.
    @kunalspathak
    kunalspathak committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    f8473ec View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Exclude DivRem.csproj

    @kunalspathak
    kunalspathak committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e00a8c1 View commit details
    Browse the repository at this point in the history

  2. Handle the case to delay-free op3 for op1/op2

    @kunalspathak
    kunalspathak committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    9e28279 View commit details
    Browse the repository at this point in the history

  3. Create the DivRem.RefOnly fake CoreLib as a reference assembly 

    Make the DivRem tests reference the DivRem fake
CoreLib as reference assembly; and ensure that it is not included as a
ProjectReference by the toplevel HardwareIntrinsics merged test
runners.

The upshot is that the DivRem tests can call the extra APIs via
a direct reference to CoreLib (instead of through System.Runtime), but
the fake library is not copied into any test artifact directories, and
the Mono AOT compiler never sees it.
    @kunalspathak
    kunalspathak committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2d4d8d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Unify AddDelayFreeUses

    @kunalspathak
    kunalspathak committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    b5e3dd3 View commit details
    Browse the repository at this point in the history