Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SocketsHttpHandler's default connect timeout to 15s #66607

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

CarnaViire
Copy link
Member

Unifies default ConnectTimeout for Windows and Linux. The value is less than default Windows socket timeout (21s) to minimize the race between timeout exception and socket exception.

Fixes #66297

@ghost
Copy link

ghost commented Mar 14, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Unifies default ConnectTimeout for Windows and Linux. The value is less than default Windows socket timeout (21s) to minimize the race between timeout exception and socket exception.

Fixes #66297

Author: CarnaViire
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub merged commit 436b97c into dotnet:main Mar 15, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
* Set default connect timeout to 15s

* Fix ConnectTimeout_Default test
@karelz karelz added this to the 7.0.0 milestone Apr 8, 2022
CarnaViire added a commit to CarnaViire/runtime that referenced this pull request Apr 28, 2022
stephentoub pushed a commit that referenced this pull request Apr 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change SocketsHttpHandler's default ConnectTimeout to a reasonable finite value
4 participants