[MAUI][PERF] Maui Perf add iOS Podcast SOD Tests #67165
Conversation
|
Tagging subscribers to this area: @hoyosjs Issue Detailsnull
|
LoopedBard3
changed the title
| chmod -R a+r . | ||
| # remove net6.0-maccatalyst to work around https://github.com/dotnet/sdk/issues/21877 | ||
| cp Microsoft.NetConf2021.Maui.csproj Microsoft.NetConf2021.Maui.csproj.bak | ||
| sed -i'' -e 's/net6.0-ios;net6.0-maccatalyst/net6.0-ios/g' Microsoft.NetConf2021.Maui.csproj |
There was a problem hiding this comment.
I bet we can come up with a sed line that will survive more classes of csproj file edits. I'll pester you in person.
There was a problem hiding this comment.
Working on this: #67263
There was a problem hiding this comment.
Will merge this, then copy the sed change to this section.
| @@ -172,6 +172,7 @@ if ($iOSMono) { | |||
| Copy-Item -path "$SourceDirectory\iosHelloWorld\nollvm" $PayloadDirectory\iosHelloWorld\nollvm -Recurse | |||
| Copy-Item -path "$SourceDirectory\MauiiOSDefaultIPA" $PayloadDirectory\MauiiOSDefaultIPA -Recurse | |||
| Copy-Item -path "$SourceDirectory\MauiMacCatalystDefault\MauiMacCatalystDefault.app" $PayloadDirectory\MauiMacCatalystDefault -Recurse | |||
| Copy-Item -path "$SourceDirectory\MauiiOSPodcastIPA" $PayloadDirectory\MauiiOSPodcastIPA -Recurse | |||
There was a problem hiding this comment.
This section of performance-setup seems awfully test case specific for a script with such a general name. Probably naively optimistic of me, but are there any ways we could move move test case specific knowledge closer to the test cases?
There was a problem hiding this comment.
I think it's probably possible to take care of a lot of this with the yml templates, so we have a template that just takes a list of apps, and expands to the various stuff for them.
I was reluctant to try to do that given deadlines and the difficulty in debugging yml templates though. It would be a good thing to tackle in the future.
There was a problem hiding this comment.
I added this as an area of improvement: dotnet/performance#2113. This is 100% something we should at least look into.
There was a problem hiding this comment.
Yeah, in particular we are impacted by the fact that we only want to build the apps once, but use them in various test cases. That goes against some of the assumptions around how our scenario support was built. We don't need to design the feature in this comment thread, but I think that trying to bring the concept of pre-building dependencies of scenarios into our current python scenario execution code is where we should focus our efforts.
|
Changes don't impact any of the main runtime testing and a manual run succeeded, merging. |
* Publish the maui iOS Podcast app in the build yml * Pipe the built Podcast IPA file through and test it.
ghost
locked as resolved and limited conversation to collaborators
No description provided.