-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Span.Reverse test coverage #68493
Conversation
… as they are going to share the logic soon
Tagging subscribers to this area: @dotnet/area-system-memory Issue DetailsWhile reviewing #64412 I've realized that we need more tests for Since both
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to be addressed, but otherwise LGTM.
While reviewing #64412 I've realized that we need more tests for
Span.Reverse
.Since both
Array.Reverse
andSpan.Reverse
are going to use the same logic, we can't no longer useArray.Reverse
to produce the expected output forSpan.Reverse
(any bug would go unnoticed)