Change some delegate FCalls to managed

[huoyaoyuan]

Benchmark:

        [UnmanagedCallersOnly]
        static void X() { }

        private readonly Action _fnptr1 = Marshal.GetDelegateForFunctionPointer<Action>((nint)(delegate* unmanaged<void>)(&X));
        private readonly Action _fnptr2 = Marshal.GetDelegateForFunctionPointer<Action>((nint)(delegate* unmanaged<void>)(&X));

        private readonly Action _action1 = () => Console.WriteLine("A");
        private readonly Action _action2 = () => Console.WriteLine("B");

        private readonly Func<int> _actionInt1 = Func;
        private readonly Func<int> _actionInt2 = Func;

        public static int Func() => 42;

        [Benchmark]
        public bool UnmanagedEquals() => _fnptr1 == _fnptr2;

        [Benchmark]
        public Action Combine() => _action1 + _action2;

        [Benchmark]
        public bool ManagedEquals() => _actionInt1 == _actionInt2;
        
        [Benchmark]
        public bool ManagedNotEquals() => _action1 == _action2;

        [Benchmark]
        public bool TypeMismatch() => _action1.Equals(_actionInt1);

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
UnmanagedEquals	Job-SQNAXT	\PR\corerun.exe	2.895 ns	0.0151 ns	0.0133 ns	0.50
UnmanagedEquals	Job-GXCCWM	\main\corerun.exe	5.844 ns	0.0553 ns	0.0490 ns	1.00
Combine	Job-SQNAXT	\PR\corerun.exe	42.868 ns	0.2113 ns	0.1765 ns	0.95
Combine	Job-GXCCWM	\main\corerun.exe	45.173 ns	0.3683 ns	0.3445 ns	1.00
ManagedEquals	Job-SQNAXT	\PR\corerun.exe	6.934 ns	0.0747 ns	0.0624 ns	0.58
ManagedEquals	Job-GXCCWM	\main\corerun.exe	11.938 ns	0.0670 ns	0.0560 ns	1.00
ManagedNotEquals	Job-SQNAXT	\PR\corerun.exe	94.570 ns	0.7560 ns	0.7072 ns	0.94
ManagedNotEquals	Job-GXCCWM	\main\corerun.exe	100.963 ns	1.5713 ns	1.4697 ns	1.00
TypeMismatch	Job-SQNAXT	\PR\corerun.exe	1.587 ns	0.0117 ns	0.0097 ns	0.17
TypeMismatch	Job-GXCCWM	\main\corerun.exe	9.482 ns	0.0368 ns	0.0326 ns	1.00

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Benchmark:

        [UnmanagedCallersOnly]
        static void X() { }

        private readonly Action _fnptr1 = Marshal.GetDelegateForFunctionPointer<Action>((nint)(delegate* unmanaged<void>)(&X));
        private readonly Action _fnptr2 = Marshal.GetDelegateForFunctionPointer<Action>((nint)(delegate* unmanaged<void>)(&X));

        private readonly Action _action1 = () => Console.WriteLine("A");
        private readonly Action _action2 = () => Console.WriteLine("B");

        private readonly Func<int> _actionInt1 = Func;
        private readonly Func<int> _actionInt2 = Func;

        public static int Func() => 42;

        [Benchmark]
        public bool UnmanagedEquals() => _fnptr1 == _fnptr2;

        [Benchmark]
        public Action Combine() => _action1 + _action2;

        [Benchmark]
        public bool ManagedEquals() => _actionInt1 == _actionInt2;
        
        [Benchmark]
        public bool ManagedNotEquals() => _action1 == _action2;

        [Benchmark]
        public bool TypeMismatch() => _action1.Equals(_actionInt1);

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
UnmanagedEquals	Job-SQNAXT	\PR\corerun.exe	2.895 ns	0.0151 ns	0.0133 ns	0.50
UnmanagedEquals	Job-GXCCWM	\main\corerun.exe	5.844 ns	0.0553 ns	0.0490 ns	1.00
Combine	Job-SQNAXT	\PR\corerun.exe	42.868 ns	0.2113 ns	0.1765 ns	0.95
Combine	Job-GXCCWM	\main\corerun.exe	45.173 ns	0.3683 ns	0.3445 ns	1.00
ManagedEquals	Job-SQNAXT	\PR\corerun.exe	6.934 ns	0.0747 ns	0.0624 ns	0.58
ManagedEquals	Job-GXCCWM	\main\corerun.exe	11.938 ns	0.0670 ns	0.0560 ns	1.00
ManagedNotEquals	Job-SQNAXT	\PR\corerun.exe	94.570 ns	0.7560 ns	0.7072 ns	0.94
ManagedNotEquals	Job-GXCCWM	\main\corerun.exe	100.963 ns	1.5713 ns	1.4697 ns	1.00
TypeMismatch	Job-SQNAXT	\PR\corerun.exe	1.587 ns	0.0117 ns	0.0097 ns	0.17
TypeMismatch	Job-GXCCWM	\main\corerun.exe	9.482 ns	0.0368 ns	0.0326 ns	1.00

Author:	huoyaoyuan
Assignees:	-
Labels:	area-System.Runtime, community-contribution
Milestone:	-

[huoyaoyuan]

The contract of IsEquivalentTo_Worker is GC_TRIGGER, so a helper method frame is still required?

[am11]

Perhaps GCX_COOP is better suited for these MethodTable helpers? AFAIK, converting these FCalls to QCall (or pure managed) is a general goodness, e.g.

runtime/src/coreclr/vm/qcallentrypoints.cpp

Line 110 in e67e4da

DllImportEntry(RuntimeMethodHandle_GetTypicalMethodDefinition)

[jkotas]

Yes, it would be better to change this to QCall while you are on it.

[huoyaoyuan]

How to pass MethodTable in QCall then? Since it's a pointer into unmanaged runtime, it should be safe to directly pass the pointer?

[jkotas]

Yes, pass it as pointer

[jkotas]

The test failures are #64544 + Helix infrastructure intermittent failure.

[jkotas]

Thank you!