Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Newtonsoft.Json from 12.0.3 to 13.0.1 in /src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer #71180

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 23, 2022

Bumps Newtonsoft.Json from 12.0.3 to 13.0.1.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.1

  • New feature - Add JsonSelectSettings with configuration for a regex timeout
  • Change - Remove portable assemblies from NuGet package
  • Change - JsonReader and JsonSerializer MaxDepth defaults to 64
  • Fix - Fixed throwing missing member error on ignored fields
  • Fix - Fixed various nullable annotations
  • Fix - Fixed annotations not being copied when tokens are cloned
  • Fix - Fixed naming strategy not being used when deserializing dictionary enum keys
  • Fix - Fixed serializing nullable struct dictionaries
  • Fix - Fixed JsonWriter.WriteToken to allow null with string token
  • Fix - Fixed missing error when deserializing JToken with a contract type mismatch
  • Fix - Fixed JTokenWriter when writing comment to an object
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 23, 2022
@ghost
Copy link

ghost commented Jun 23, 2022

Tagging subscribers to this area: @dotnet/area-dependencymodel
See info in area-owners.md if you want to be subscribed.

Issue Details

Bumps Newtonsoft.Json from 12.0.3 to 13.0.1.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.1

  • New feature - Add JsonSelectSettings with configuration for a regex timeout
  • Change - Remove portable assemblies from NuGet package
  • Change - JsonReader and JsonSerializer MaxDepth defaults to 64
  • Fix - Fixed throwing missing member error on ignored fields
  • Fix - Fixed various nullable annotations
  • Fix - Fixed annotations not being copied when tokens are cloned
  • Fix - Fixed naming strategy not being used when deserializing dictionary enum keys
  • Fix - Fixed serializing nullable struct dictionaries
  • Fix - Fixed JsonWriter.WriteToken to allow null with string token
  • Fix - Fixed missing error when deserializing JToken with a contract type mismatch
  • Fix - Fixed JTokenWriter when writing comment to an object
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Author: dependabot[bot]
Assignees: -
Labels:

area-DependencyModel, .NET

Milestone: -

@dependabot dependabot bot force-pushed the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch from 4af13b3 to 3b9853d Compare June 23, 2022 11:44
@akoeplinger
Copy link
Member

The failures in runtime (Build Browser wasm Linux Release LibraryTests) look related:

Application startup exception: System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Could not load file or assembly 'Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The system cannot find the file specified.

   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.Assembly.GetTypes()
   at Microsoft.DotNet.XHarness.CLI.CommandArguments.TypeFromAssemblyArgument`1.GetLoadedTypes()+MoveNext() in /_/src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Arguments/TypeFromAssemblyArgument.cs:line 29
   at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.<>c__DisplayClass0_0.<Start>b__9(TestWebServerOptions options) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 60
   at Microsoft.Extensions.Options.OptionsFactory`1.Create(String name)
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
   at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
   at System.Lazy`1.CreateValue()
   at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd(String name, Func`1 createOptions)
   at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.TestWebServerStartup.Configure(IApplicationBuilder app, IOptionsMonitor`1 optionsAccessor) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 126
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Span`1& arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at Microsoft.AspNetCore.Hosting.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder)
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
   at Microsoft.AspNetCore.Hosting.WebHost.BuildApplication()

@lewing @radical

@ghost
Copy link

ghost commented Jul 5, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Bumps Newtonsoft.Json from 12.0.3 to 13.0.1.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.1

  • New feature - Add JsonSelectSettings with configuration for a regex timeout
  • Change - Remove portable assemblies from NuGet package
  • Change - JsonReader and JsonSerializer MaxDepth defaults to 64
  • Fix - Fixed throwing missing member error on ignored fields
  • Fix - Fixed various nullable annotations
  • Fix - Fixed annotations not being copied when tokens are cloned
  • Fix - Fixed naming strategy not being used when deserializing dictionary enum keys
  • Fix - Fixed serializing nullable struct dictionaries
  • Fix - Fixed JsonWriter.WriteToken to allow null with string token
  • Fix - Fixed missing error when deserializing JToken with a contract type mismatch
  • Fix - Fixed JTokenWriter when writing comment to an object
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Author: dependabot[bot]
Assignees: -
Labels:

area-System.Net, community-contribution, .NET

Milestone: -

@radical
Copy link
Member

radical commented Jul 6, 2022

Why are we updating this version, and only for this specific project? Do we need to update $(NewtonsoftJsonVersion) too?

eng/Versions.props:    <NewtonsoftJsonVersion>12.0.3</NewtonsoftJsonVersion>
eng/testing/xunit/xunit.props:    <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj:    <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />

@am11
Copy link
Member

am11 commented Jul 11, 2022

Do we need to update $(NewtonsoftJsonVersion) too?

Updated in #71402. The only file I had to revert is NetCoreServer.csproj (in 3a1fd4d) which this PR is updating. It looks like we have some clash with xharness (or a similar dependency) which pulls in older newtonsoft and breaks the build (with the same error / callstack as #71180 (comment)). I didn't investigated it further.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 2, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@MihaZupan MihaZupan reopened this Aug 2, 2022
@dependabot dependabot bot force-pushed the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch from 3b9853d to bcaa385 Compare August 2, 2022 17:36
@MihaZupan
Copy link
Member

xharness updated this in dotnet/xharness#930 and dotnet/xharness#932

@MihaZupan MihaZupan closed this Aug 7, 2022
@dependabot dependabot bot deleted the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 7, 2022 22:38
@MihaZupan MihaZupan restored the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 7, 2022 22:38
@MihaZupan MihaZupan reopened this Aug 7, 2022
@dependabot dependabot bot force-pushed the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch from bcaa385 to 7ff4a02 Compare August 7, 2022 22:39
@am11
Copy link
Member

am11 commented Aug 7, 2022

@MihaZupan, it needs dotnet/arcade#9962 (and probably an update from xharness running the updated arcade)

@garath
Copy link
Member

garath commented Aug 8, 2022

it needs dotnet/arcade#9962 (and probably an update from xharness running the updated arcade)

Arcade and xharness should be using up-to-date Newtonsoft.Json packages as of last week (earlier for Arcade). Certainly let us know if something looks amiss.

@am11
Copy link
Member

am11 commented Aug 8, 2022

Great. I suppose we are waiting for #72934 and #73517.

@MihaZupan MihaZupan closed this Aug 13, 2022
@dependabot dependabot bot deleted the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 13, 2022 18:42
@MihaZupan MihaZupan restored the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 13, 2022 18:42
@MihaZupan MihaZupan reopened this Aug 13, 2022
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.1.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
- [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.1)

---
updated-dependencies:
- dependency-name: Newtonsoft.Json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch from 7ff4a02 to f4b8d8a Compare August 13, 2022 18:42
…ver/NetCoreServer.csproj

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@MihaZupan MihaZupan added this to the 7.0.0 milestone Aug 15, 2022
@MihaZupan MihaZupan merged commit 62d1d42 into main Aug 15, 2022
@dependabot dependabot bot deleted the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 15, 2022 16:06
@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2022
@jeffhandley jeffhandley removed the community-contribution Indicates that the PR has been added by a community member label Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants