-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Newtonsoft.Json from 12.0.3 to 13.0.1 in /src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer #71180
Conversation
Tagging subscribers to this area: @dotnet/area-dependencymodel Issue DetailsBumps Newtonsoft.Json from 12.0.3 to 13.0.1. Release notesSourced from Newtonsoft.Json's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting Dependabot commands and optionsYou can trigger Dependabot actions by commenting on this PR:
You can disable automated security fix PRs for this repo from the Security Alerts page.
|
4af13b3
to
3b9853d
Compare
The failures in
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBumps Newtonsoft.Json from 12.0.3 to 13.0.1. Release notesSourced from Newtonsoft.Json's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting Dependabot commands and optionsYou can trigger Dependabot actions by commenting on this PR:
You can disable automated security fix PRs for this repo from the Security Alerts page.
|
Why are we updating this version, and only for this specific project? Do we need to update eng/Versions.props: <NewtonsoftJsonVersion>12.0.3</NewtonsoftJsonVersion>
eng/testing/xunit/xunit.props: <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj: <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" /> |
Updated in #71402. The only file I had to revert is |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
3b9853d
to
bcaa385
Compare
xharness updated this in dotnet/xharness#930 and dotnet/xharness#932 |
bcaa385
to
7ff4a02
Compare
@MihaZupan, it needs dotnet/arcade#9962 (and probably an update from xharness running the updated arcade) |
Arcade and xharness should be using up-to-date Newtonsoft.Json packages as of last week (earlier for Arcade). Certainly let us know if something looks amiss. |
src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/NetCoreServer.csproj
Outdated
Show resolved
Hide resolved
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
7ff4a02
to
f4b8d8a
Compare
…ver/NetCoreServer.csproj Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Bumps Newtonsoft.Json from 12.0.3 to 13.0.1.
Release notes
Sourced from Newtonsoft.Json's releases.
Commits
ae9fe44
Remove compiler package and update sourcelink (#2498)8ef6621
Remove prerelease for 13.0.111331f5
Update SDK to 5.0.200 (#2495)c7e8abc
Update to 13.0.1-beta21745d7c
Fix JTokenWriter when writing comment to an object (#2493)583eb12
Fix missing error when deserializing JToken with a contract type mismatch (#2...b6dc05b
Change MaxDepth default to 64 (#2473)15525f1
Fix JsonWriter.WriteToken to allow null with string token (#2472)926d2f0
Enable embed untracked sources (#2471)0a56633
Fixes #2372 - variable typos (#2465)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.