Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Binary Xml (XmlDictionaryWriter) performance #71478

Merged
merged 30 commits into from
Apr 1, 2023
Merged

Improve Binary Xml (XmlDictionaryWriter) performance #71478

merged 30 commits into from
Apr 1, 2023

Commits on Jun 29, 2022

  1. Improve perf of XmlBinaryWriter using Unsafe

    @Daniel-Svensson
    Daniel-Svensson committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    c327b28 View commit details
    Browse the repository at this point in the history

  2. Use ReverseEndianness to simplify writes

    @Daniel-Svensson
    Daniel-Svensson committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    d57b7f2 View commit details
    Browse the repository at this point in the history

  3. Use span in a few places

    @Daniel-Svensson
    Daniel-Svensson committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    c214302 View commit details
    Browse the repository at this point in the history

  4. Add back old comparison, but only write float as int if it saves space

    @Daniel-Svensson
    Daniel-Svensson committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    0e736f6 View commit details
    Browse the repository at this point in the history

  5. Use span in array writing to reduce bounds checks

    @Daniel-Svensson
    Daniel-Svensson committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    d1e850b View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Extract all unsafe code to shared method

    @Daniel-Svensson
    Daniel-Svensson committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    d80b67f View commit details
    Browse the repository at this point in the history

  2. Fix nodetype type

    @Daniel-Svensson
    Daniel-Svensson committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    d24de76 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2022

  1. Avoid pinning and unsafe when writing arrays

    @Daniel-Svensson
    Daniel-Svensson committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    c98689b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into dev

    @Daniel-Svensson
    Daniel-Svensson committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    cf64f69 View commit details
    Browse the repository at this point in the history

  3. add back CheckArray

    @Daniel-Svensson
    Daniel-Svensson committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    450e4d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Fix Assert condition

    @Daniel-Svensson
    Daniel-Svensson committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    149b6d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @Daniel-Svensson @stephentoub
    Daniel-Svensson and stephentoub committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    2907e0a View commit details
    Browse the repository at this point in the history

  2. Fix review comments

    @Daniel-Svensson
    Daniel-Svensson committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    86496bb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into dev

    @Daniel-Svensson
    Daniel-Svensson committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    ed26c86 View commit details
    Browse the repository at this point in the history

  4. use new span ctor

    @Daniel-Svensson
    Daniel-Svensson committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    657e9b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. add tests

    @Daniel-Svensson
    Daniel-Svensson committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    0a7a7e5 View commit details
    Browse the repository at this point in the history

  2. Add tests for very long arrays

    @Daniel-Svensson
    Daniel-Svensson committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    963315d View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Fixx overload resolution for WriteText method

    @Daniel-Svensson
    Daniel-Svensson committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    c2e11d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Just copy guid arrays on LittleEndian platforms

    @Daniel-Svensson
    Daniel-Svensson committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e832548 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. Merge remote-tracking branch 'upstream/main' into dev

    @Daniel-Svensson
    Daniel-Svensson committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    1d1818e View commit details
    Browse the repository at this point in the history

  2. Add testversion of XmlBinaryNodeType with hardcoded values to use sam… 

    …e appoach as in reader PR
    @Daniel-Svensson
    Daniel-Svensson committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    571a628 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. call corrreect version of getbuffer

    @Daniel-Svensson
    Daniel-Svensson committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    5488341 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Merge branch 'main' into dev

    @Daniel-Svensson
    Daniel-Svensson committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c983179 View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/System.Runtime.Serialization.Xml/tests/Reflectio… 

    …nOnly/System.Runtime.Serialization.Xml.ReflectionOnly.Tests.csproj
    @Daniel-Svensson
    Daniel-Svensson committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ce69dce View commit details
    Browse the repository at this point in the history

  3. fix merge conflict

    @Daniel-Svensson
    Daniel-Svensson committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    9281073 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Fix merge conflicts.

    @StephenMolloy
    StephenMolloy committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    798286a View commit details
    Browse the repository at this point in the history

  2. Restored Big-Endian functionality. Ugly though.

    @StephenMolloy
    StephenMolloy committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ab3e0cc View commit details
    Browse the repository at this point in the history

  3. Cleaned up arrays.

    @StephenMolloy
    StephenMolloy committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    477cf8b View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. Merge branch 'main' into dev

    @StephenMolloy
    StephenMolloy committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    f51e07d View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Remove leftover using in tests.

    @StephenMolloy
    StephenMolloy committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    1fb4ba0 View commit details
    Browse the repository at this point in the history