Port the incremental source generator polyfill code to the 6.0 servicing branch. #72219

CyrusNajmabadi · 2022-07-14T21:01:18Z

Backport of: #71653 and #71651.

Bulk of code added in #70911. However that PR also updated the RegexGenerator (which does not exist in 6.0 and thus does not need to be serviced).

Note: this is a polyfill of an API that roslyn has added. Once SDK can move to a version of roslyn containing the api, it can reference that API directly and remove the 1000 lines of added code for the polyfill.

Servicing Template:

Description:

Primary goal here is to use a more efficient incrementally built up system for determining what classes should be examined to see if we need the source generators to run. Previously, all types in a solution would be examined (costly in CPU and memory), now only types with attributes on it (that we can show could actually bind to the desired attribute) are checked. As in practice this is a tiny subset of actual types in a solution (often zero) this vastly decreases the amount of work we needed to be done.

--

Port was very clean, requiring only one deviating line between it and the code that exists in the 7.0 line.

Customer Impact:

Improved performance of 'in box' generators when in visual studio. The existing two generators cause lots of CPU and memory churn when processing. This is because each of them effectively walks all files/types looking for potential matches. This forces continual reparsing of files, and then lots of semantic binding on potential matches. For large projects (consider thousands of files being normal), this is an enormous amount of work that can use tons of CPU and memory. In Roslyn this can be particularly bad, leading to our server getting bogged down and slowing down all language services.

The new approach uses the incremental generator engine to incrementally build up a list of 'actually viable classes' to examine. The intuition generally being: if you only care about types with "JsonSerializable" on them, then only check types that have that attribute on it syntactically. This is slightly more involved than just a trivial name check because things like aliases/global-aliases mean that someone could go global using Foo = System.Text.Json.JsonSerializable; in one file and then [Foo] class MyClass in another. However, with this, we can narrow down to only the set of types that are actually relevant, not all types. Furthermore, in projects that reference the sdk but do not use the generator at all, there will be zero potential matches, and so no semantic work has to happen at all.

Regression?

Yes. This was a perf (but not functionality) regression for anyone with a large solution and who moved to .net 6. Note taht a customer doesn't need to be using the generator to have the perf hit. Just referencing the SDK is enough as it will cause Roslyn to run the generator, which does all expensive work, just to determine that is has nothing to generate.

Risk

I would consider this low. This is a non-trivial amount of code going in. However, it has been extensively tested in roslyn, with a large test suite, and has been validated for the 7.0 sdk. That said, incremental source generation is itself complex (one of the reasons that the perf issue arose in teh first place), so this is definitely more than a trivial fix.

Link the PR to the original issue and to the PR to main.

Issue PR:
#70754

Main PRs:
#71653
#71651
#70911

This was multiple PRs as i separated out the initial polyfill, and then did a single PR per generator to update.

Note any packaging impact. (If the changes touch code in a package that we ship out of band (OOB) then we will need to take care to ensure those packages ship.)

Yes. This impacts the Microsoft.Extensions.Logging.Abstractions NuGet package as well as the System.Text.Json NuGet package. Those two ship source generators that are being edited here so we will need to service those two.

Note any ref pack impact. (Touches files contained in Microsoft.NETCore.App.Ref, Microsoft.AspNetCore.App.Ref, or Microsoft.WindowsDesktop.App.Ref).

Yes. This impacts the Microsoft.NETCore.App.Ref since the Json Source generator ships in the ref pack as well, and it is being serviced by this change.

…ing branch.

dotnet-issue-labeler · 2022-07-14T21:01:24Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

CyrusNajmabadi · 2022-07-14T21:02:31Z

src/libraries/Common/src/Roslyn/CSharpSyntaxHelper.cs

@@ -0,0 +1,125 @@
+// Licensed to the .NET Foundation under one or more agreements.


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:02:40Z

src/libraries/Common/src/Roslyn/GetBestTypeByMetadataName.cs

@@ -1,7 +1,10 @@
 // Licensed to the .NET Foundation under one or more agreements.


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:02:44Z

src/libraries/Common/src/Roslyn/GlobalAliases.cs

@@ -0,0 +1,74 @@
+// Licensed to the .NET Foundation under one or more agreements.


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:02:48Z

src/libraries/Common/src/Roslyn/Hash.cs

@@ -0,0 +1,24 @@
+// Licensed to the .NET Foundation under one or more agreements.


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:02:52Z

src/libraries/Common/src/Roslyn/ISyntaxHelper.cs

@@ -0,0 +1,66 @@
+// Licensed to the .NET Foundation under one or more agreements.


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:02:57Z

src/libraries/Common/src/Roslyn/SyntaxNodeGrouping.cs

@@ -0,0 +1,42 @@
+// Licensed to the .NET Foundation under one or more agreements.


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:03:03Z

src/libraries/Common/src/Roslyn/SyntaxValueProvider.ImmutableArrayValueComparer.cs

@@ -0,0 +1,29 @@
+// Licensed to the .NET Foundation under one or more agreements.


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:03:07Z

src/libraries/Common/src/Roslyn/SyntaxValueProvider_ForAttributeWithMetadataName.cs

@@ -0,0 +1,201 @@
+// Licensed to the .NET Foundation under one or more agreements.


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:03:13Z

src/libraries/Common/src/Roslyn/SyntaxValueProvider_ForAttributeWithSimpleName.cs

@@ -0,0 +1,400 @@
+// Licensed to the .NET Foundation under one or more agreements.


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:04:00Z

src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs

            private const string JsonSourceGenerationOptionsAttributeFullName = "System.Text.Json.Serialization.JsonSourceGenerationOptionsAttribute";

+            internal const string JsonSerializableAttributeFullName = "System.Text.Json.Serialization.JsonSerializableAttribute";


single deviation. In 7.0 line this was renamed (from Serializer -> Serializable). I kept the 7.0 name (more correct), requiring teh update to line 243 below.

CyrusNajmabadi · 2022-07-14T21:04:16Z

src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs

@@ -18,7 +18,7 @@ public partial class LoggerMessageGenerator
    {


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:04:19Z

src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Roslyn4.0.cs

@@ -7,6 +7,7 @@
 using System.Text;


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:04:23Z

...Extensions.Logging.Abstractions/gen/Microsoft.Extensions.Logging.Generators.Roslyn4.0.csproj

@@ -8,6 +8,20 @@



Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:04:29Z

src/libraries/System.Text.Json/gen/JsonSourceGenerator.Roslyn4.0.cs

@@ -11,6 +11,7 @@
 using Microsoft.CodeAnalysis;


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:04:32Z

src/libraries/System.Text.Json/gen/System.Text.Json.SourceGeneration.Roslyn4.0.csproj

@@ -13,4 +13,18 @@
    <Compile Include="JsonSourceGenerator.Roslyn4.0.cs" />


Exact copy of 7.0 line.

CyrusNajmabadi · 2022-07-14T21:04:34Z

src/libraries/System.Text.RegularExpressions/src/System.Text.RegularExpressions.csproj

@@ -6,7 +6,6 @@
  </PropertyGroup>


Exact copy of 7.0 line.

src/libraries/System.Text.RegularExpressions/src/System.Text.RegularExpressions.csproj

…th packages that need to be serviced.

joperezr · 2022-07-14T23:50:49Z

The failure in OSX seems to be related. Looks like an issue with the Logging generator:

CSC : error CS8785: Generator 'LoggerMessageGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'IndexOutOfRangeException' with message 'Index was outside the bounds of the array.' [/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.csproj]
##[error]CSC(0,0): error CS8785: (NETCORE_ENGINEERING_TELEMETRY=Build) Generator 'LoggerMessageGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'IndexOutOfRangeException' with message 'Index was outside the bounds of the array.'
CSC : error CS8785: Generator 'LoggerMessageGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'IndexOutOfRangeException' with message 'Index was outside the bounds of the array.' [/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.csproj]
##[error]CSC(0,0): error CS8785: (NETCORE_ENGINEERING_TELEMETRY=Build) Generator 'LoggerMessageGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'IndexOutOfRangeException' with message 'Index was outside the bounds of the array.'
/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/MiscTestExtensions.cs(10,32): error CS8795: Partial method 'NoNamespace.CouldNotOpenSocket(ILogger, string)' must have an implementation part because it has accessibility modifiers. [/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.csproj]
##[error]src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/MiscTestExtensions.cs(10,32): error CS8795: (NETCORE_ENGINEERING_TELEMETRY=Build) Partial method 'NoNamespace.CouldNotOpenSocket(ILogger, string)' must have an implementation part because it has accessibility modifiers.
/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/MiscTestExtensions.cs(19,36): error CS8795: Partial method 'OneLevelNamespace.CouldNotOpenSocket(ILogger, string)' must have an implementation part because it has accessibility modifiers. [/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.csproj]
##[error]src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/MiscTestExtensions.cs(19,36): error CS8795: (NETCORE_ENGINEERING_TELEMETRY=Build) Partial method 'OneLevelNamespace.CouldNotOpenSocket(ILogger, string)' must have an implementation part because it has accessibility modifiers.
/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/MiscTestExtensions.cs(31,40): error CS8795: Partial method 'TwoLevelNamespace.CouldNotOpenSocket(ILogger, string)' must have an implementation part because it has accessibility modifiers. [/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.csproj]
##[error]src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/MiscTestExtensions.cs(31,40): error CS8795: (NETCORE_ENGINEERING_TELEMETRY=Build) Partial method 'TwoLevelNamespace.CouldNotOpenSocket(ILogger, string)' must have an implementation part because it has accessibility modifiers.
/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/ArgTestExtensions.cs(11,36): error CS8795: Partial method 'ArgTestExtensions.Method1(ILogger)' must have an implementation part because it has accessibility modifiers. [/Users/runner/work/1/s/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.csproj]
##[error]src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/ArgTestExtensions.cs(11,36): error CS8795: (NETCORE_ENGINEERING_TELEMETRY=Build) Partial method 'ArgTestExtensions.Method1(ILogger)' must have an implementation part because it has accessibility modifiers.

joperezr · 2022-07-18T19:22:06Z

cc: @layomia @eiriktsarpalis @steveharter for the Json Source generator changes.
cc: @eerhardt @maryamariyan for the Logging generator changes.

eiriktsarpalis

STJ changes LGTM.

ghost · 2022-07-19T13:38:49Z

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Draft until i make sure i didn't break anything.

Backport of: #71653 and #71651.

Bulk of code added in #70911. However that PR also updated the RegexGenerator (which does not exist in 6.0 and thus does not need to be serviced).

Note: this is a polyfill of an API that roslyn has added. Once SDK can move to a version of roslyn containing the api, it can reference that API directly and remove the 1000 lines of added code for the polyfill.

Servicing Template:

Description:

Primary goal here is to use a more efficient incrementally built up system for determining what classes should be examined to see if we need the source generators to run. Previously, all types in a solution would be examined (costly in CPU and memory), now only types with attributes on it (that we can show could actually bind to the desired attribute) are checked. As in practice this is a tiny subset of actual types in a solution (often zero) this vastly decreases the amount of work we needed to be done.

--

Port was very clean, requiring only one deviating line between it and the code that exists in the 7.0 line.

Customer Impact:

Improved performance of 'in box' generators when in visual studio. The existing two generators cause lots of CPU and memory churn when processing. This is because each of them effectively walks all files/types looking for potential matches. This forces continual reparsing of files, and then lots of semantic binding on potential matches. For large projects (consider thousands of files being normal), this is an enormous amount of work that can use tons of CPU and memory. In Roslyn this can be particularly bad, leading to our server getting bogged down and slowing down all language services.

The new approach uses the incremental generator engine to incrementally build up a list of 'actually viable classes' to examine. The intuition generally being: if you only care about types with "JsonSerializable" on them, then only check types that have that attribute on it syntactically. This is slightly more involved than just a trivial name check because things like aliases/global-aliases mean that someone could go global using Foo = System.Text.Json.JsonSerializable; in one file and then [Foo] class MyClass in another. However, with this, we can narrow down to only the set of types that are actually relevant, not all types. Furthermore, in projects that reference the sdk but do not use the generator at all, there will be zero potential matches, and so no semantic work has to happen at all.

Regression?

Yes. This was a perf (but not functionality) regression for anyone with a large solution and who moved to .net 6. Note taht a customer doesn't need to be using the generator to have the perf hit. Just referencing the SDK is enough as it will cause Roslyn to run the generator, which does all expensive work, just to determine that is has nothing to generate.

Risk

I would consider this low. This is a non-trivial amount of code going in. However, it has been extensively tested in roslyn, with a large test suite, and has been validated for the 7.0 sdk. That said, incremental source generation is itself complex (one of the reasons that the perf issue arose in teh first place), so this is definitely more than a trivial fix.

Link the PR to the original issue and to the PR to main.

Issue PR:
#70754

Main PRs:
#71653
#71651
#70911

This was multiple PRs as i separated out the initial polyfill, and then did a single PR per generator to update.

Note any packaging impact. (If the changes touch code in a package that we ship out of band (OOB) then we will need to take care to ensure those packages ship.)

Yes. This impacts the Microsoft.Extensions.Logging.Abstractions NuGet package as well as the System.Text.Json NuGet package. Those two ship source generators that are being edited here so we will need to service those two.

Note any ref pack impact. (Touches files contained in Microsoft.NETCore.App.Ref, Microsoft.AspNetCore.App.Ref, or Microsoft.WindowsDesktop.App.Ref).

Yes. This impacts the Microsoft.NETCore.App.Ref since the Json Source generator ships in the ref pack as well, and it is being serviced by this change.

Author:	CyrusNajmabadi
Assignees:	CyrusNajmabadi
Labels:	`Servicing-consider`, `area-Extensions-Logging`
Milestone:	6.0.x

eerhardt

Logging generator changes LGTM

rbhanda · 2022-07-19T17:47:00Z

Merge depends on 17.4 Preview 1 testing.

ghost · 2022-08-02T21:19:51Z

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of: #71653 and #71651.

Bulk of code added in #70911. However that PR also updated the RegexGenerator (which does not exist in 6.0 and thus does not need to be serviced).

Note: this is a polyfill of an API that roslyn has added. Once SDK can move to a version of roslyn containing the api, it can reference that API directly and remove the 1000 lines of added code for the polyfill.

Servicing Template:

Description:

Primary goal here is to use a more efficient incrementally built up system for determining what classes should be examined to see if we need the source generators to run. Previously, all types in a solution would be examined (costly in CPU and memory), now only types with attributes on it (that we can show could actually bind to the desired attribute) are checked. As in practice this is a tiny subset of actual types in a solution (often zero) this vastly decreases the amount of work we needed to be done.

--

Port was very clean, requiring only one deviating line between it and the code that exists in the 7.0 line.

Customer Impact:

Improved performance of 'in box' generators when in visual studio. The existing two generators cause lots of CPU and memory churn when processing. This is because each of them effectively walks all files/types looking for potential matches. This forces continual reparsing of files, and then lots of semantic binding on potential matches. For large projects (consider thousands of files being normal), this is an enormous amount of work that can use tons of CPU and memory. In Roslyn this can be particularly bad, leading to our server getting bogged down and slowing down all language services.

The new approach uses the incremental generator engine to incrementally build up a list of 'actually viable classes' to examine. The intuition generally being: if you only care about types with "JsonSerializable" on them, then only check types that have that attribute on it syntactically. This is slightly more involved than just a trivial name check because things like aliases/global-aliases mean that someone could go global using Foo = System.Text.Json.JsonSerializable; in one file and then [Foo] class MyClass in another. However, with this, we can narrow down to only the set of types that are actually relevant, not all types. Furthermore, in projects that reference the sdk but do not use the generator at all, there will be zero potential matches, and so no semantic work has to happen at all.

Regression?

Yes. This was a perf (but not functionality) regression for anyone with a large solution and who moved to .net 6. Note taht a customer doesn't need to be using the generator to have the perf hit. Just referencing the SDK is enough as it will cause Roslyn to run the generator, which does all expensive work, just to determine that is has nothing to generate.

Risk

I would consider this low. This is a non-trivial amount of code going in. However, it has been extensively tested in roslyn, with a large test suite, and has been validated for the 7.0 sdk. That said, incremental source generation is itself complex (one of the reasons that the perf issue arose in teh first place), so this is definitely more than a trivial fix.

Link the PR to the original issue and to the PR to main.

Issue PR:
#70754

Main PRs:
#71653
#71651
#70911

This was multiple PRs as i separated out the initial polyfill, and then did a single PR per generator to update.

Note any packaging impact. (If the changes touch code in a package that we ship out of band (OOB) then we will need to take care to ensure those packages ship.)

Yes. This impacts the Microsoft.Extensions.Logging.Abstractions NuGet package as well as the System.Text.Json NuGet package. Those two ship source generators that are being edited here so we will need to service those two.

Note any ref pack impact. (Touches files contained in Microsoft.NETCore.App.Ref, Microsoft.AspNetCore.App.Ref, or Microsoft.WindowsDesktop.App.Ref).

Yes. This impacts the Microsoft.NETCore.App.Ref since the Json Source generator ships in the ref pack as well, and it is being serviced by this change.

Author:	CyrusNajmabadi
Assignees:	CyrusNajmabadi
Labels:	`Servicing-approved`, `area-Meta`
Milestone:	6.0.9

tarekgh · 2022-08-02T21:20:08Z

I labeled it Meta as it is covering multiple areas.

carlossanlop · 2022-08-11T19:50:05Z

Merge depends on 17.4 Preview 1 testing.

@rbhanda who should take care of this so I can merge it?

src/libraries/System.Text.Json/src/System.Text.Json.csproj

carlossanlop · 2022-08-15T17:33:58Z

Merge depends on 17.4 Preview 1 testing.

@rbhanda @joperezr @CyrusNajmabadi is this good to merge or do we still need confirmation of the testing? Today is the due date for merging backports that we intend to add to the September servicing release.

carlossanlop · 2022-08-15T23:36:47Z

Tactics approved.
Milestone applied.
CI passed.
OOB package authoring changes included.
Signed off by area owners.
From a chat conversation with @joperezr, we didn't hear about any testing issues, so we're good.
Ready to merge!

CyrusNajmabadi added 3 commits July 14, 2022 13:52

Port the incremental source generator polyfill code to the 6.0 servic…

ecc4ede

…ing branch.

Use common code

671c6c7

Add logging extensions

3124240

CyrusNajmabadi requested a review from joperezr July 14, 2022 21:01

ghost assigned CyrusNajmabadi Jul 14, 2022

CyrusNajmabadi commented Jul 14, 2022

View reviewed changes

teo-tsirpanis added this to the 6.0.x milestone Jul 14, 2022

CyrusNajmabadi requested review from jaredpar and stephentoub July 14, 2022 21:25

joperezr reviewed Jul 14, 2022

View reviewed changes

src/libraries/System.Text.RegularExpressions/src/System.Text.RegularExpressions.csproj Outdated Show resolved Hide resolved

Fix typo on project Compile item and enable producing packages for bo…

6385d08

…th packages that need to be serviced.

Allow ValueListBuilder to work with empty scratch spans (#70917)

9ee1f8b

joperezr marked this pull request as ready for review July 18, 2022 19:15

joperezr requested review from steveharter, layomia and eiriktsarpalis as code owners July 18, 2022 19:15

joperezr added the Servicing-consider Issue for next servicing release review label Jul 18, 2022

eiriktsarpalis approved these changes Jul 19, 2022

View reviewed changes

jeffschwMSFT added the area-Extensions-Logging label Jul 19, 2022

eerhardt approved these changes Jul 19, 2022

View reviewed changes

rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 19, 2022

rbhanda modified the milestones: 6.0.x, 6.0.9 Jul 19, 2022

tarekgh added area-Meta and removed area-Extensions-Logging labels Aug 2, 2022

carlossanlop reviewed Aug 11, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System.Text.Json.csproj Show resolved Hide resolved

carlossanlop merged commit 5a0d081 into release/6.0 Aug 15, 2022

carlossanlop deleted the portPolyfill branch August 15, 2022 23:37

ghost locked as resolved and limited conversation to collaborators Sep 15, 2022

		@@ -0,0 +1,125 @@
		// Licensed to the .NET Foundation under one or more agreements.

		@@ -1,7 +1,10 @@
		// Licensed to the .NET Foundation under one or more agreements.

		@@ -0,0 +1,74 @@
		// Licensed to the .NET Foundation under one or more agreements.

		@@ -0,0 +1,24 @@
		// Licensed to the .NET Foundation under one or more agreements.

		@@ -0,0 +1,66 @@
		// Licensed to the .NET Foundation under one or more agreements.

		@@ -0,0 +1,42 @@
		// Licensed to the .NET Foundation under one or more agreements.

		@@ -0,0 +1,29 @@
		// Licensed to the .NET Foundation under one or more agreements.

		@@ -0,0 +1,201 @@
		// Licensed to the .NET Foundation under one or more agreements.

		@@ -0,0 +1,400 @@
		// Licensed to the .NET Foundation under one or more agreements.

		private const string JsonSourceGenerationOptionsAttributeFullName = "System.Text.Json.Serialization.JsonSourceGenerationOptionsAttribute";

		internal const string JsonSerializableAttributeFullName = "System.Text.Json.Serialization.JsonSerializableAttribute";

		@@ -18,7 +18,7 @@ public partial class LoggerMessageGenerator
		{

		@@ -13,4 +13,18 @@
		<Compile Include="JsonSourceGenerator.Roslyn4.0.cs" />

Port the incremental source generator polyfill code to the 6.0 servicing branch. #72219

Port the incremental source generator polyfill code to the 6.0 servicing branch. #72219

Conversation

CyrusNajmabadi commented Jul 14, 2022 • edited Loading

Servicing Template:

Description:

Customer Impact:

Regression?

Risk

Link the PR to the original issue and to the PR to main.

Note any packaging impact. (If the changes touch code in a package that we ship out of band (OOB) then we will need to take care to ensure those packages ship.)

Note any ref pack impact. (Touches files contained in Microsoft.NETCore.App.Ref, Microsoft.AspNetCore.App.Ref, or Microsoft.WindowsDesktop.App.Ref).

dotnet-issue-labeler bot commented Jul 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joperezr commented Jul 14, 2022

joperezr commented Jul 18, 2022

eiriktsarpalis left a comment

Choose a reason for hiding this comment

ghost commented Jul 19, 2022

Servicing Template:

Description:

Customer Impact:

Regression?

Risk

Link the PR to the original issue and to the PR to main.

Note any packaging impact. (If the changes touch code in a package that we ship out of band (OOB) then we will need to take care to ensure those packages ship.)

Note any ref pack impact. (Touches files contained in Microsoft.NETCore.App.Ref, Microsoft.AspNetCore.App.Ref, or Microsoft.WindowsDesktop.App.Ref).

eerhardt left a comment

Choose a reason for hiding this comment

rbhanda commented Jul 19, 2022

ghost commented Aug 2, 2022

Servicing Template:

Description:

Customer Impact:

Regression?

Risk

Link the PR to the original issue and to the PR to main.

Note any packaging impact. (If the changes touch code in a package that we ship out of band (OOB) then we will need to take care to ensure those packages ship.)

Note any ref pack impact. (Touches files contained in Microsoft.NETCore.App.Ref, Microsoft.AspNetCore.App.Ref, or Microsoft.WindowsDesktop.App.Ref).

tarekgh commented Aug 2, 2022 • edited Loading

carlossanlop commented Aug 11, 2022

carlossanlop commented Aug 15, 2022

carlossanlop commented Aug 15, 2022

CyrusNajmabadi commented Jul 14, 2022 •

edited

Loading

tarekgh commented Aug 2, 2022 •

edited

Loading