Avoid adding an HttpClient.Timeout message to ConnectTimeout exceptions #72274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #67505
|
MihaZupan
commented
Jul 15, 2022
| } | ||
|
|
||
| [Fact] | ||
| public async Task UnknownOperationCanceledException_NotWrappedInATimeoutException() |
There was a problem hiding this comment.
Looking into it a bit more, there was a broader issue here where we would classify any unknown OCE (not just ConnectTimeout) as HttpClient.Timeout.
I tweaked the checks somewhat to catch such cases as well.
CarnaViire
reviewed
Jul 19, 2022
src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
|
Failures are #72428 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67505