Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run pipelines on .devcontainer changes #72295

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Do not run pipelines on .devcontainer changes #72295

merged 1 commit into from
Jul 16, 2022

Conversation

vcsjones
Copy link
Member

As observed in #72287, changing files in .devcontainer should not have any material impact on the build or CI. These files are used entirely for GitHub Codespaces, so it should be treated similarly as the .github directory.

@ghost ghost assigned vcsjones Jul 15, 2022
@ghost
Copy link

ghost commented Jul 15, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

As observed in #72287, changing files in .devcontainer should not have any material impact on the build or CI. These files are used entirely for GitHub Codespaces, so it should be treated similarly as the .github directory.

Author: vcsjones
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: -

@ghost
Copy link

ghost commented Jul 15, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

As observed in #72287, changing files in .devcontainer should not have any material impact on the build or CI. These files are used entirely for GitHub Codespaces, so it should be treated similarly as the .github directory.

Author: vcsjones
Assignees: vcsjones
Labels:

area-Infrastructure
Milestone: -

@radical
Copy link
Member

radical commented Jul 16, 2022

Failure is #71233, and unrelated to this PR.

@radical radical merged commit 55bf5d8 into dotnet:main Jul 16, 2022
@vcsjones vcsjones deleted the pipelines-dev-container branch July 16, 2022 03:01
@ghost ghost locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@vcsjones vcsjones

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vcsjones @radical @jkoritzinsky