Fix typos

[am11]

Second commit cleans up trailing whitespaces in files from first commit.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Second commit cleans up trailing whitespaces in files from first commit.

Author:	am11
Assignees:	-
Labels:	area-System.Reflection.Metadata, community-contribution
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Second commit cleans up trailing whitespaces in files from first commit.

Author:	am11
Assignees:	-
Labels:	area-Meta, community-contribution
Milestone:	-

[jkotas]

Test failure is #69125

[jkotas]

@brianrob Is it ok to fix typos in opcode names here or would that be a breaking change?

[jkotas]

@am11 Could you please revert the change in the opcode names for now?

[jkotas]

Maybe open an issue on it so that it is not forgotten.

[am11]

Reverted and opened #72324.

[brianrob]

Changing the opcode name could be considered a breaking change, depending upon how the events are consumed. I would not expect the string id to be a breaking change unless someone was looking for a specific string that they've hardcoded somewhere, but I wouldn't worry about that. For the most part, we have not fixed typos for opcodes, keywords, event names, and fields to avoid these types of breaks since there are lots of consumers out there that use string values instead of integer ids.

[am11]

For reference, this time I used a tool called typos in Ubuntu container, to collect the data then used jq to find most recurring typos. This is the self-contained unix script (assumes C compiler / build-essential package on Ubuntu, jq and curl are preinstalled and PWD is root of runtime):

categorize-typos.sh

#!/bin/sh

if [ "$1" = '-h' ] || [ "$1" = "--help" ] || [ "$1" = "-?" ]; then
  echo "Usage: $0 or $0 <to> <from>\n\nExample - to get most recurring typos in a git repo in 20 to 50 window:\n  $0 20 50\n\nDefaults are from: 0 to: 100"
  exit 0
fi

if ! command -v rustc 2>/dev/null; then
  echo "Installing rust .."
  curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
fi

if ! command -v cargo 2>/dev/null; then
  echo "Setting up cargo environment .."
  . "$HOME/.cargo/env"
fi

if ! command -v typos 2>/dev/null; then
  echo "Installing 'typos' crate .."
  cargo install typos-cli
fi

echo "Collecting typos data in list.json .."
# (assuming working directory is root of 'runtime' so it respects .gitignore rules)
typos --format=json > list.json

# we don't use other features of typos tool (such as "apply corrections") -- only collecting data.

echo "Analyzing data using jq .."

# group typos by name, sort by their frequency and display N items (default 0 to 100)
from="${1:-0}" to="${2:-100}"

jq --slurp --argjson from $from --argjson to $to --compact-output \
  '[ group_by(.typo)[] | {word: .[0].typo, count: length, correction: (if .[0].corrections then .[0].corrections | join(", ") else "" end) } ] | sort_by(.count) | reverse | .[$from:$to]' list.json |\
  jq -r '["Count","Word", "Available Corrections"], ["--","------","------"], (.[] | [.count,.word,.correction]) | @tsv'

(I'm sure the last part can be improved and squashed into one jq command, still warming up to jq language syntax 😁)

There were some false-positives so i created a quick (non-exhaustive) .typos.toml file (which typos-cli uses) at root of runtime with these contents (more words can be added):

[default.extend-words]
ba = "ba"
fo = "fo"
nd = "nd"
ot = "ot"
ue = "ue"
ser = "ser"
BA = "BA"
Ba = "Ba"
inout = "inout"
SEH = "SEH"

These two files are for "finding" typos and not checked in, as there is manual work involved for the next step; "fixing" typos.

To fix the correction repo-wide, I used manual find & replace approach: git grep -l $incorrect | xargs -I{} sed -i "s/$incorrect/$correct/g" {}, then reverted changes in restricted places such as src/libraries/*/ref/*, src/native/external, eng/common, *.xlfetc. Sometimes it required renaming the files with typo as well, to find those files, I used: git ls-files | grep -i $incorrect, then moved them manually (using mv or git mv).

[jkotas]

Crossgen2TasksOverriden is used in dotnet/sdk. Fixing this one would have to be coordinated between repos and runtime versions, probably not worth it. Could you please revert this one?

[jkotas]

This file is Brazil Portuguese. Is supporte correct? Bing translator shows it with single p.

[am11]

I didn't noticed it, thanks. It is reverted. I will treat wxl like xlf in the future. :)

[jkotas]

LGTM. Thanks!