Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] enable more tests for web sockets #72843

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

pavelsavara
Copy link
Member

Just removed the active issue. To see if it still happens with the web sockets based on JSImport

fixes #53957
fixes #57519

@pavelsavara pavelsavara added this to the 7.0.0 milestone Jul 26, 2022
@pavelsavara pavelsavara requested a review from radical July 26, 2022 10:44
@pavelsavara pavelsavara self-assigned this Jul 26, 2022
@ghost
Copy link

ghost commented Jul 26, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Just removed the active issue. To see if it still happens with the web sockets based on JSImport

fixes #53957
fixes #57519

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 7.0.0

@pavelsavara pavelsavara marked this pull request as ready for review July 26, 2022 14:47
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@pavelsavara pavelsavara requested a review from lewing July 26, 2022 14:48
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

The failure is #72880

@pavelsavara pavelsavara requested a review from maraf July 27, 2022 07:23
@pavelsavara pavelsavara merged commit c867be6 into dotnet:main Jul 27, 2022
@pavelsavara pavelsavara deleted the wasm_ws_tests branch July 29, 2022 09:16
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants