Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eventpipe] Use MonoImage:module_name when filename is NULL #73018

Merged
merged 3 commits into from
Aug 1, 2022
Merged

[eventpipe] Use MonoImage:module_name when filename is NULL #73018

merged 3 commits into from
Aug 1, 2022

Commits on Jul 28, 2022

  1. [eventpipe] Use MonoImage:name when available, if MonoImage:filename … 

    …is null

When assemblies are bundled (for example in WASM), the filename field
is set to NULL and the name field is set to the basename of the
assembly.
    @lambdageek
    lambdageek committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    11abaa0 View commit details
    Browse the repository at this point in the history

  2. Update src/mono/mono/eventpipe/ep-rt-mono.c

    @lambdageek
    lambdageek committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    4152c28 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. use the module name, not image->name 

    module name comes from the metadata Module table and is something like
"Foo.dll" even if the assembly is loaded from a bundle or from
Assembly.Load(byte[]), whereas image->name might be "data-0x00abcdef"
for byte loads
    @lambdageek
    lambdageek committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    2009c30 View commit details
    Browse the repository at this point in the history