[wasm-mt] Fixup C exports initialization after startup.ts refactoring #73158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
requested review from
lewing,
pavelsavara and
lateralusX
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixup issues due to d7c8bc1:
|
lambdageek
commented
Aug 1, 2022
pavelsavara
reviewed
Aug 1, 2022
pavelsavara
approved these changes
Aug 1, 2022
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
force-pushed
the
wasm-mt-pthread-cwraps
branch
2 times, most recently
from
623a0bd
to
1acad8d
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1. Copy the mono_wasm_pre_init_essential code into mono_wasm_pthread_worker_init in order to set up the C bindings infrastructure in the workers. 2. Because `mono_wasm_pthread_worker_init` runs in the middle of Emscripten's initialization (before all the Emscripten properties on `Module` are assigned) always use lazy cwraps initialization (the issue is `Module["cwrap"]` hasn't been set yet)
lambdageek
force-pushed
the
wasm-mt-pthread-cwraps
branch
from
1acad8d
to
23a6031
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
oops, I meant to do that to my other PR. this one is ok. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup issues due to d7c8bc1:
init_c_exportslazily on pthread workers, always. Eager initialization doesn't work because at the time that our code runs, Emscripten hasn't fully initializedModuleyet (in particularModule["cwraps"]hasn't been assigned yet).mono_wasm_pthread_worker_initdirectly frominitializeImportsAndExports- calling it frompreInitdoesn't work because Emscripten doesn't runpreInitin pthread workers. Also there's a technical change here to return aPromise<EmscriptenModule>- Emscripten is good with this because they use.theninworker.jsand it's good for us because we can do async initialization at this point (for example waiting for the channel to the main browser thread to get established)