-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update heap hard limit for large pages #73508
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsFixes #54616 This bug is for segments only, some of the segment size calculations may increase the total size allocated. To make sure all allocated memory can be used (without being limited by the heap hard limit), the heap hard limit should be increased to match the allocated memory.
|
since this only affects certain platforms now, is it worth taking for 7? |
One way or the other, we need to get this bug out of 7.0.0. We can either fix it, won't fix it, or move the bug to 8. Here are some info helpful for the decision:
Let me know what we want to do with this bug. |
lets move to 8 for now and then we can determine what to do then. |
4e9866e
to
2e0f5b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4027925993 |
Fixes #54616
This bug is for segments only, some of the segment size calculations may increase the total size allocated. To make sure all allocated memory can be used (without being limited by the heap hard limit), the heap hard limit should be increased to match the allocated memory.