Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heap hard limit for large pages #73508

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

cshung
Copy link
Member

@cshung cshung commented Aug 6, 2022

Fixes #54616

This bug is for segments only, some of the segment size calculations may increase the total size allocated. To make sure all allocated memory can be used (without being limited by the heap hard limit), the heap hard limit should be increased to match the allocated memory.

@ghost
Copy link

ghost commented Aug 6, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #54616

This bug is for segments only, some of the segment size calculations may increase the total size allocated. To make sure all allocated memory can be used (without being limited by the heap hard limit), the heap hard limit should be increased to match the allocated memory.

Author: cshung
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

@cshung cshung added this to the 7.0.0 milestone Aug 6, 2022
@mangod9
Copy link
Member

mangod9 commented Aug 6, 2022

since this only affects certain platforms now, is it worth taking for 7?

@cshung
Copy link
Member Author

cshung commented Aug 6, 2022

since this only affects certain platforms now, is it worth taking for 7?

One way or the other, we need to get this bug out of 7.0.0. We can either fix it, won't fix it, or move the bug to 8. Here are some info helpful for the decision:

  • This is a corner case, it is unexpected for workloads to run under segments and using large pages and specified a hard limit that is not aligned.
  • But this is fatal, if it is not specified correctly, the startup or subsequent virtual commit calls will fail.

Let me know what we want to do with this bug.

@mangod9
Copy link
Member

mangod9 commented Aug 12, 2022

lets move to 8 for now and then we can determine what to do then.

@mangod9 mangod9 modified the milestones: 7.0.0, 8.0.0 Aug 12, 2022
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshung cshung merged commit d7d6354 into dotnet:main Sep 20, 2022
@cshung cshung deleted the public/update-hard-limit branch September 20, 2022 22:36
@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2022
@cshung
Copy link
Member Author

cshung commented Jan 27, 2023

/backport to release/7.0

@github-actions github-actions bot unlocked this conversation Jan 27, 2023
@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4027925993

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure hard limit and large pages work together when the hard limits are not page aligned.
3 participants