Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] net7.0 + net6.0 workload multitargeting changes #74018

Merged
merged 46 commits into from
Aug 22, 2022

Conversation

lewing
Copy link
Member

@lewing lewing commented Aug 16, 2022

No description provided.

@ghost
Copy link

ghost commented Aug 16, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: lewing
Assignees: -
Labels:

area-System.Net

Milestone: -

@ghost
Copy link

ghost commented Aug 16, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: lewing
Assignees: lewing
Labels:

area-System.Net, area-Infrastructure-mono

Milestone: -

@lewing lewing changed the base branch from main to release/7.0-rc1 August 17, 2022 01:09
@lewing lewing changed the title Net7 workload changes [release/7.0-rc1] Net7 workload changes Aug 17, 2022
@lewing lewing closed this Aug 17, 2022
@lewing lewing reopened this Aug 17, 2022
@lewing lewing closed this Aug 17, 2022
@lewing lewing reopened this Aug 17, 2022
radical and others added 2 commits August 18, 2022 08:43
Don't use **FromWorkload** for pack versions because it doesn't understand the name aliasing we have to use with runtime packs
@lewing lewing force-pushed the net7-workload-changes branch 2 times, most recently from 0dc04d2 to 3af277a Compare August 20, 2022 01:28
@radical
Copy link
Member

radical commented Aug 20, 2022

/azp run runtime, runtime-staging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

radical and others added 5 commits August 20, 2022 23:29
When running a fresh build with `dotnet build`, the first one works
fine. But all the subsequent builds fail with no info in the logs at
all.

```
 $ /workspaces/runtime/artifacts/bin/dotnet-net7/dotnet build
MSBuild version 17.4.0-preview-22413-01+f0a66ec43 for .NET

Build FAILED.
    0 Warning(s)
    0 Error(s)
```

And it seems to be related to msbuild nodes, so disable NodeReuse.
@lewing
Copy link
Member Author

lewing commented Aug 21, 2022

@dsplaisted @marcpopMSFT

      [] /datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/sdk/7.0.100-rc.2.22419.24/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(219,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/datadisks/disk1/work/93E60831/w/A8A8094E/e/blz_aot_prj_file_Release/blz_aot_prj_file_Release.csproj]
      [] /datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/sdk/7.0.100-rc.2.22419.24/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(448,5): error NETSDK1109: Runtime list file '/datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/data/RuntimeList.xml' was not found. Report this error to the .NET team here: https://aka.ms/dotnet-sdk-issue. [/datadisks/disk1/work/93E60831/w/A8A8094E/e/blz_aot_prj_file_Release/blz_aot_prj_file_Release.csproj]

it appears to be looking up the runtime pack in the packs directory without a version on the pack

/datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/data/RuntimeList.xml doesn't exist but /datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/7.0.0-ci/data/RuntimeList.xml does

@lewing
Copy link
Member Author

lewing commented Aug 21, 2022

@marcpopMSFT could it be dotnet/sdk@0bc1ff8

@lewing
Copy link
Member Author

lewing commented Aug 22, 2022

Found the issue on our side, the tests were including a bunch of outdated logic that was breaking things

@lewing lewing requested a review from steveisok August 22, 2022 01:25
@radical
Copy link
Member

radical commented Aug 22, 2022

Approved, assuming the CI is green.

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the ci is green

@lewing lewing merged commit 754014e into release/7.0-rc1 Aug 22, 2022
@lewing lewing deleted the net7-workload-changes branch August 22, 2022 05:02
// second, and subsequent builds fail without any details
// in the logs
EnvVars["DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER"] = "1";
DefaultBuildArgs += " /nr:false";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have an issue filed for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be related to this one: dotnet/sdk#26965 (comment)
But with newer builds of the SDK, I was able to take out this workaround.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants