Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to build PGO tools on platforms with no CoreCLR port. #74147

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

directhex
Copy link
Member

Closes: #74102

@directhex directhex added arch-s390x Related to s390x architecture (unsupported) arch-ppc64le labels Aug 18, 2022
@ghost ghost assigned directhex Aug 18, 2022
@ghost
Copy link

ghost commented Aug 18, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes: #74102

Author: directhex
Assignees: -
Labels:

area-Infrastructure-coreclr, arch-s390x, arch-ppc64le

Milestone: -

eng/Subsets.props Outdated Show resolved Hide resolved
eng/Subsets.props Outdated Show resolved Hide resolved
@directhex directhex merged commit c8b0d87 into dotnet:main Sep 2, 2022
@uweigand
Copy link
Contributor

uweigand commented Sep 2, 2022

Thanks @directhex - I've confirmed that native builds on s390x now work again.

Can this be backported to net7 to fix the regression there?

@directhex
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2980253578

@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-ppc64le arch-s390x Related to s390x architecture (unsupported) area-Infrastructure-coreclr
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Native build on s390x broken after PR #72394
3 participants