[release/7.0] Only stack allocate when marshalling Utf8 arguments #74553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
MichalStrehovsky
approved these changes
Aug 25, 2022
|
@jeffschwMSFT can we get an approval? |
jkotas
approved these changes
Aug 25, 2022
|
@JulieLeeMSFT can we get an approval on Jeff's behalf? |
tommcdon
approved these changes
Aug 25, 2022
|
Approved and signed off. CI green. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74478 to release/7.0
/cc @MichalStrehovsky
Customer Impact
Marshaling of string fields as UTF-8 causes a memory corruption in NativeAOT.
Testing
Extended NativeAOT smoke tests to cover the scenario. Ran all src/tests/Interop tests.
Risk
Only affects UTF-8 marshalling.