[release/7.0] For perf, remove Invoker pattern for fields #74693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsBackport of #74614 to release/7.0 /cc @steveharter Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@danmoseley or @ericstj need an approval please. Does this meet the bar? |
|
Approved, significant regression over past release. |
carlossanlop
approved these changes
Aug 28, 2022
There was a problem hiding this comment.
Thanks @danmoseley for the approval.
Signing off so I can merge it.
CI is green.
Ready to merge. 
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74614 to release/7.0
/cc @steveharter
Customer Impact
Addresses perf regressions when getting fields (~16% regression) or setting fields (~2% regression) with reflection.
With the changes, there is no longer a regression getting fields, and an improvement of about 13% setting fields.
Testing
The standard runtime- and reflection-based tests.
Risk
Low; the existing code was essentially reverted to a previous state that was fully tested.