[release/7.0] Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. #74738
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Workaround crash hit by #74179 making sure we avoid hitting codepath emitting this null pointer checks. The full fix includes codegen fixes as well, but will be performed in separate PR. There are still locations in SpanHelper.T.cs that uses Equal virtual call on value types that could be managed pointers to value types, but that code has remained the same for the last 4 years to 15 months and have not hit this issue in the past.
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsBackport of #74567 to release/7.0 /cc @lateralusX Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
Tagging subscribers to this area: @dotnet/area-system-memory Issue DetailsBackport of #74567 to release/7.0 /cc @lateralusX Fixes #74179. Re-enable tests previously disabled by #74454. Customer ImpactTestingRe-enable failing tests as part of fix. Full test suites run and pass on main with tests re-enabled and fix implemented. RiskLow. IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
Approved for RC2 - basic functionality regressed. Will customers notice this in RC1 ? |
I think we can leave RC1 as is for now, in special cases code might read pass allocated buffer by max 3 bytes, so only if buffer is last on allocated page and next page is either unallocated or explicitly marked without read access this will crash in case were runtime runs with implicit null checks. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #74567 to release/7.0
/cc @lateralusX
Fixes #74179.
Re-enable tests previously disabled by #74454.
Customer Impact
Testing
Re-enable failing tests as part of fix. Full test suites run and pass on main with tests re-enabled and fix implemented.
Risk
Low.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.