[release/7.0] Fix TransactionInterop.GetDtcTransaction() #74821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Incorrect COM interop definition Fixes #74745
AaronRobinsonMSFT
approved these changes
Aug 30, 2022
|
@ajcvickers need an approval please. |
ajcvickers
approved these changes
Aug 30, 2022
ajcvickers
removed
the
Servicing-consider
|
@danmoseley Need M2 approval for this. |
|
@Pilchie we need an approval, please. |
|
Not sure whether this is me or @Pilchie , perhaps me because it's this repo. Approved -- new 7.0 scenario broken. |
|
@danmoseley Thanks. Assumed it was you because it is in this repo. @roji Ready to merge. |
|
Approved and signed off. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74776 to release/7.0
/cc @roji
Customer Impact
The TransactionInterop.GetDtcTransaction() method, which is part of the Windows-only distributed transaction support introduced for .NET 7.0, does not work.
Testing
Coverage added in the PR.
Risk
Very low. The change is part of a feature only introduced in .NET 7.0; the function in question threw PlatformNotSupportedException previously. The fix is a simple correction of the COM interop definition which the function implementation uses.
/cc @AaronRobinsonMSFT @ajcvickers