[release/7.0] Change some exception types thrown in Tar APIs #74893
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…or called by all other public conversion constructors. Add missing test gap.
…ble exception should be ArgumentException.
…passed an unreadable stream.
…o ArgumentException.
…stream. Add missing exception docs.
…, adjust docs and tests.
…ser tries to set an empty string. Add tests.
carlossanlop
requested review from
bartonjs,
danmoseley,
adamsitnik and
jozkee
|
@rainersigwald @baronfel heads up: if this gets approved and merged, it will go into RC2 and may cause failures in the sdk containers repo in the dependency updates PR. I can help fix the problems if you ping me. |
|
This PR was executed 2h before the CI went down for maintenance. I asked the maintenance folks if the running CI legs were allowed to finish, or killed silently. If the former, then this is good. If the latter, I'll have to close and reopen the PR to re-run CI. Awaiting confirmation. |
|
Update: I was told the safe thing to do is to close and reopen PRs that may have been impacted by the system being down. The CI runs might have kept running during maintenance, but the results probably didn't flow to GitHub. |
|
This was approved by @danmoseley for backport in the main PR: #74845 (comment) |
ghost
locked as resolved and limited conversation to collaborators
Backport of #74845 to release/7.0
/cc @carlossanlop
Customer Impact
We reviewed all the exceptions thrown by the System.Formats.Tar APIs and determined some of them need to be changed to a more appropriate one.
We also found a couple of bugs in places where the exceptions had to be thrown but weren't, and included them in the PR.
Testing
Added many more tests to fill some gaps, and adapted the existing ones to the new exceptions.
Risk
New assembly. The risk is low.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.