Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Revert change in StringBuilder.Append(char) #74898

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 1, 2022

Backport of #74885 to release/7.0

/cc @jkotas

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

The change has a bad interaction with inlining heuristics.

Fixes #74158. Partial revert of #67448.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Once we get a green ci we can merge

@carlossanlop
Copy link
Member

The CI was down yesterday for maintenance around 4pm. This PR was submitted at 5pm, so only 4 checks were executed. I'm closing and reopening this PR so the full CI runs.

@carlossanlop carlossanlop reopened this Sep 1, 2022
@carlossanlop
Copy link
Member

I investigated the CI failures. They are all unrelated. They are false positives: The tests finish successfully with no failures/errors, yet the results are being reported as such. I asked coreeng and they told me this is due to the strain in the Helix infrastructure. We could re-run, or just ignore. I'd say we can ignore, since the logs were readable and there were no problems.
Approved and signed off.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit ce7e864 into release/7.0 Sep 3, 2022
@carlossanlop carlossanlop deleted the backport/pr-74885-to-release/7.0 branch September 3, 2022 00:16
@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants