[release/7.0] Disallow TarWriter from writing link entries without LinkName set #74939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: David Cantú <dacantu@microsoft.com>
|
No tar test failures in the CI. |
|
Approved, as mentioned on original PR, under completing 7.0 scenarios. But this one is marginal -- it seems relatively low impact, and can be fixed in 8.0. So I don't think we'd take a change like this next week. |
jozkee
approved these changes
Sep 2, 2022
|
FYI I investigated all the test failures. They are all known false positives that coreeng told me are being caused by the Helix infrastructure being overstressed. The tests have no failures/errors, yet the process seems to be returning a failure value. Example of the output: |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74892 to release/7.0
/cc @carlossanlop
Customer Impact
If we create an archive with TarWriter, we should only allow inserting symlink/hardlink entries that have non-null and non-empty LinkName strings. Otherwise we cannot extract them using TarFile due to having an invalid link target. This is consistent with the
mklinkandlncommands, which do not allow creating links with empty targets.Testing
Added many tests to verify that TarWriter does not allow inserting symlink/hardlink entries with empty LinkName. Adjusted some existing ones as well.
Risk
Low. New feature in 7.0. Making it more robust.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.