Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CompatibilitySuppressions.xml after sorting #74954

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Update CompatibilitySuppressions.xml after sorting #74954

merged 3 commits into from
Sep 1, 2022

Conversation

smasher164
Copy link
Member

No description provided.

@ghost ghost assigned smasher164 Sep 1, 2022
@ghost
Copy link

ghost commented Sep 1, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: smasher164
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

ViktorHofer
ViktorHofer requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove new files and new suppressions. I think some of the new suppressions are false positives and might need a bugfix. Let's scope this down to only apply the sorting change.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 1, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 1, 2022
ViktorHofer
ViktorHofer approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@smasher164 smasher164 merged commit 04ca89d into dotnet:main Sep 1, 2022
@smasher164 smasher164 deleted the update-suppressions branch September 1, 2022 22:02
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@smasher164 smasher164

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smasher164 @ViktorHofer