Improve diagnostics when allocating MsQuicApi #74985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
rzikm
changed the title
liveans
approved these changes
Sep 2, 2022
liveans
reviewed
Sep 2, 2022
src/libraries/System.Net.Http/src/System/Net/Http/HttpMethod.cs
Outdated
Show resolved
Hide resolved
rzikm
force-pushed
the
msquic-api-improve-diagnostics
branch
from
a00ca20
to
7cf6eba
Compare
stephentoub
reviewed
Sep 2, 2022
| { | ||
| return new MsQuicApi(apiTable); | ||
| } | ||
|
|
||
| ThrowHelper.ThrowIfMsQuicError(openStatus); | ||
|
|
||
| // this should unreachable as TryOpenMsQuic returns non-success status on failure | ||
| throw new Exception("Failed to create MsQuicApi instance"); |
There was a problem hiding this comment.
If you were to invert this condition, you wouldn't need the unreachable throw:
if (!TryLoadMsQuic(out IntPtr msQuicHandle) || !TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable, out openStatus))
{
ThrowHelper.ThrowIfMsQuicError(openStatus);
}
return new MsQuicApi(apiTable);You could also have a ThrowMsQuicError that was unconditional. Or just use throw GetExceptionForMsQuicStatus(openStatus);.
stephentoub
approved these changes
Sep 2, 2022
|
Since the change this follows up on was reverted, I am closing this issue, we can pick these changes in #75163 and have them in 1 commit for eventual porting |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves diagnostics when allocating MsQuicApi instance, this was useful when investigating #74952 and would be nice to get into .NET 7 as part of #74931.