Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Update Roslyn compiler build #75156

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 6, 2022

Backport of #75058 to release/7.0

/cc @cston

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@cston
Copy link
Member

cston commented Sep 6, 2022

This PR is currently blocked on #75128.

@ghost
Copy link

ghost commented Sep 6, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75058 to release/7.0

/cc @cston

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@cston
Copy link
Member

cston commented Sep 6, 2022

cc @danmoseley, this change is needed for 7.0 to move to the final SDK containing an updated compiler.

@danmoseley
Copy link
Member

@cston thanks for letting me know. Seems to me this falls under "infra necessary to ship" and thus automatically approved

@cston
Copy link
Member

cston commented Sep 6, 2022

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@carlossanlop
Copy link
Member

I see source generation build failures in all the Browser legs. I wonder if they are related to this change:

Example of a job results: https://dev.azure.com/dnceng-public/public/_build/results?buildId=6110&view=logs&j=11c5c840-d20a-5536-428b-70d8cd9c6259&t=cdae1c92-5397-500e-687d-b0aafc3f5e3d&l=3169

Build failures:

System.Text.Encoding -> /__w/1/s/artifacts/bin/System.Text.Encoding/Release/net7.0/System.Text.Encoding.dll
  System.Diagnostics.StackTrace -> /__w/1/s/artifacts/bin/System.Diagnostics.StackTrace/Release/net7.0/System.Diagnostics.StackTrace.dll
  System.Net.NameResolution -> /__w/1/s/artifacts/bin/System.Net.NameResolution/Release/net7.0-browser/System.Net.NameResolution.dll
CSC : error CS9067: Analyzer reference '/__w/1/s/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll' specified multiple times [/__w/1/s/src/libraries/System.Console/src/System.Console.csproj]
##[error]CSC(0,0): error CS9067: (NETCORE_ENGINEERING_TELEMETRY=Build) Analyzer reference '/__w/1/s/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll' specified multiple times
CSC : error CS9067: Analyzer reference '/__w/1/s/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll' specified multiple times [/__w/1/s/src/libraries/System.Console/src/System.Console.csproj]
##[error]CSC(0,0): error CS9067: (NETCORE_ENGINEERING_TELEMETRY=Build) Analyzer reference '/__w/1/s/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll' specified multiple times
  System.Linq -> /__w/1/s/artifacts/bin/System.Linq/Release/net7.0-browser/System.Linq.dll
  System.Console -> /__w/1/s/artifacts/bin/System.Console/Release/net7.0-browser/System.Console.dll
  System.IO.Compression -> /__w/1/s/artifacts/bin/System.IO.Compression/Release/net7.0-browser/System.IO.Compression.dll
  System.Net.WebSockets -> /__w/1/s/artifacts/bin/System.Net.WebSockets/Release/net7.0-browser/System.Net.WebSockets.dll
  System.Net.WebSockets.Client -> /__w/1/s/artifacts/bin/System.Net.WebSockets.Client/Release/net7.0-browser/System.Net.WebSockets.Client.dll
CSC : error CS9067: Analyzer reference '/__w/1/s/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll' specified multiple times [/__w/1/s/src/libraries/System.Net.Http/src/System.Net.Http.csproj]
##[error]CSC(0,0): error CS9067: (NETCORE_ENGINEERING_TELEMETRY=Build) Analyzer reference '/__w/1/s/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll' specified multiple times
CSC : error CS9067: Analyzer reference '/__w/1/s/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll' specified multiple times [/__w/1/s/src/libraries/System.Net.Http/src/System.Net.Http.csproj]
##[error]CSC(0,0): error CS9067: (NETCORE_ENGINEERING_TELEMETRY=Build) Analyzer reference '/__w/1/s/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll' specified multiple times
  System.Net.Primitives -> /__w/1/s/artifacts/bin/System.Net.Primitives/Release/net7.0-browser/System.Net.Primitives.dll
  System.Net.Mail -> /__w/1/s/artifacts/bin/System.Net.Mail/Release/net7.0-browser/System.Net.Mail.dll
  System.Text.Encodings.Web -> /__w/1/s/artifacts/bin/System.Text.Encodings.Web/Release/net7.0-browser/System.Text.Encodings.Web.dll

cc @radical @lewing

@radical
Copy link
Member

radical commented Sep 6, 2022

CSC : error CS9067: Analyzer reference '/__w/1/s/artifacts/bin/Microsoft.Interop.SourceGeneration/Release/netstandard2.0/Microsoft.Interop.SourceGeneration.dll' specified multiple times [/__w/1/s/src/libraries/System.Console/src/System.Console.csproj]

@cston dotnet/runtime@21075ae (#75156) wasn't enough?

@cston
Copy link
Member

cston commented Sep 6, 2022

Other duplicate generator errors should be fixed by #75128 which was still in flight when this build started.

@cston cston closed this Sep 6, 2022
@cston cston reopened this Sep 6, 2022
@radical
Copy link
Member

radical commented Sep 6, 2022

Other duplicate generator errors should be fixed by #75128 which was still in flight when this build started.

so, this branch needs to merge upstream.

@carlossanlop
Copy link
Member

Approved and signed off.
CI passed after close and reopen.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 6623792 into release/7.0 Sep 7, 2022
@carlossanlop carlossanlop deleted the backport/pr-75058-to-release/7.0 branch September 7, 2022 18:42
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants