Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix Exp10M1(TSelf) and Round(TSelf, MidpointRounding) #75284

Merged
merged 5 commits into from
Sep 9, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 8, 2022

Backport of #75063 to release/7.0

/cc @tannergooding @Blokyk

Customer Impact

Users relying on the DIM (Default Interface Member) will end up with incorrect/unexpected behavior.

Testing

Additional tests covering the scenario were added.

Risk

Minimal, the impacted API surface is new for .NET 7 and so can only impact users who were taking an early dependency on the feature and who were relying on the DIM implementation.

@ghost
Copy link

ghost commented Sep 8, 2022

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75063 to release/7.0

/cc @tannergooding @Blokyk

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Numerics

Milestone: -

@carlossanlop
Copy link
Member

@tannergooding / @dakersnar need your code review sign off, please.
@danmoseley need your approval autograph, please.

@jeffhandley
Copy link
Member

@danmoseley This meets the bar as a "broken or significantly incomplete 7.0 scenario."

@jeffhandley
Copy link
Member

Failing checks thus far are infrastructure issues.

Git fetch failed with exit code: 128

@danmoseley
Copy link
Member

Approved: perfect example of completing a new scenario based on customer feedback

@carlossanlop
Copy link
Member

The llvmfullaot leg has been running for almost 4h. I wonder if it's stuck: https://dev.azure.com/dnceng-public/public/_build/results?buildId=8964&view=logs&j=d631b51d-8d68-5da3-5a13-95f6a763c7bb
I'm seeing other backport PRs with these legs taking way too long. I'll ask FR.

@carlossanlop
Copy link
Member

Ok, CI finished and is green.

@carlossanlop carlossanlop merged commit acf0dd2 into release/7.0 Sep 9, 2022
@carlossanlop carlossanlop deleted the backport/pr-75063-to-release/7.0 branch September 9, 2022 04:13
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants