Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: run local struct to field update in morph both pre and post order for returns #75304

Merged
merged 2 commits into from
Sep 13, 2022

Commits on Sep 8, 2022

  1. JIT: run local assertion prop before morphing return of local struct …

    …to field
    
    In some rare cases (currently only jitstress) morph may miss out in updating a
    return of a "struct that can be replaced by its field" with the field, because
    we run local assertion prop afterward we check for this update, and assertion
    prop, and it may change the local from one that could not be updated into one
    that could be.
    
    So do a special run of assertion prop before this update, so that the local we
    analyze for possible update is same the one we'll be using in the end.
    
    I tried moving all of this to post-order so local assertion prop only ran
    once but that lead to more diffs and some regressions.
    
    Fixes dotnet#74900.
    AndyAyersMS committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    4795c46 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Configuration menu
    Copy the full SHA
    217140d View commit details
    Browse the repository at this point in the history