[release/7.0] Fix GCEvent::Wait with timeout on OSX #75316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #75298 to release/7.0 /cc @VSadov Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jkotas
approved these changes
Sep 9, 2022
|
@jeffschwMSFT need your stamp of approval, please. |
|
Signed off, approved, CI is a shiny bright green. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75298 to release/7.0
/cc @VSadov
Customer Impact
We were using uninitialized
endTimeinGCEvent::Waitwhen waiting on a conditional variable on OSX.This can result in unpredictable behavior. On NativeAOT it results in BGC starting without a signal and asserting/crashing.
Testing
Risk
Low: we are replacing a nondeterministic timeout with a value that we use on all other platforms.