[release/7.0] Do not emit mangled names in mstat files #75407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There's a 16 MB limit on total number of bytes in the string heap of an ECMA-335 module. S.R.Metadata throws an exception when the limit is reached. We can't even generate MSTAT files for an ASP.NET WebApi template. MSTAT files are useful even without this information, but I would like to generate it in the future. Using some different approach.
github-actions
bot
requested a review
from MichalStrehovsky
as a code owner
jkotas
approved these changes
Sep 11, 2022
jeffschwMSFT
approved these changes
Sep 12, 2022
|
The installer CI failure seems unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75328 to release/7.0
/cc @MichalStrehovsky
Customer Impact
This fixed an issue in generating managed code statistics in the native AOT compiler. This is an undocumented switch that we can use to help customers understand the size impact of their code (sample here: #73913 (comment)). We'll probably have better tooling for this in 8.0, this is a stopgap.
Testing
Made sure the asp.net scenario can generate mstat file.
Risk
This code only runs when an undocumented property is enabled. The risk is close to zero.