Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0][wasm] Fix broken dotnet-runtime-perf #75408

Merged
merged 1 commit into from
Sep 12, 2022
Merged

[release/7.0][wasm] Fix broken dotnet-runtime-perf #75408

merged 1 commit into from
Sep 12, 2022

Conversation

radical
Copy link
Member

@radical radical commented Sep 11, 2022 •
edited
Loading

Build SizeOnDisk, and Startup tools for net7.0 instead of net6.0.

It current fails with:

error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.10)
error NU1102:   - Found 2073 version(s) in dotnet6 [ Nearest version: 6.0.2-servicing.1.22101.5 ]
error NU1102:   - Found 1520 version(s) in dotnet7 [ Nearest version: 7.0.0-alpha.1.21417.28 ]
error NU1102:   - Found 1120 version(s) in dotnet5 [ Nearest version: 6.0.0-alpha.1.20420.3 ]
error NU1102:   - Found 76 version(s) in dotnet3.1 [ Nearest version: 3.1.1-servicing.19602.11 ]
error NU1102:   - Found 52 version(s) in dotnet-public [ Nearest version: 7.0.0-preview.1.22076.8 ]
error NU1102:   - Found 1 version(s) in dotnet-eng [ Nearest version: 5.0.0-alpha.1.19618.1 ]
error NU1102:   - Found 0 version(s) in benchmark-dotnet-prerelease
error NU1102:   - Found 0 version(s) in dotnet-tools
error NU1102:   - Found 0 version(s) in dotnet3.1-transport
error NU1102:   - Found 0 version(s) in dotnet5-transport

@radical radical added arch-wasm WebAssembly architecture perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines labels Sep 11, 2022
@radical
Copy link
Member Author

radical commented Sep 11, 2022

/azp run runtime-wasm

@ghost ghost assigned radical Sep 11, 2022
@ghost
Copy link

ghost commented Sep 11, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

perf pipeline: build SizeOnDisk with tfm=net7.0

Author: radical
Assignees: -
Labels:

arch-wasm, perf-pipeline
Milestone: -

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Sep 11, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

perf pipeline: build SizeOnDisk with tfm=net7.0

Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-coreclr, perf-pipeline
Milestone: -

@radical
Copy link
Member Author

radical commented Sep 11, 2022

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
[wasm] Fix perf-pipeline errors
a4916da 
Build SizeOnDisk, and Startup tools for `net7.0` instead of `net6.0`.

It current fails with:

```
error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.10)
error NU1102:   - Found 2073 version(s) in dotnet6 [ Nearest version: 6.0.2-servicing.1.22101.5 ]
error NU1102:   - Found 1520 version(s) in dotnet7 [ Nearest version: 7.0.0-alpha.1.21417.28 ]
error NU1102:   - Found 1120 version(s) in dotnet5 [ Nearest version: 6.0.0-alpha.1.20420.3 ]
error NU1102:   - Found 76 version(s) in dotnet3.1 [ Nearest version: 3.1.1-servicing.19602.11 ]
error NU1102:   - Found 52 version(s) in dotnet-public [ Nearest version: 7.0.0-preview.1.22076.8 ]
error NU1102:   - Found 1 version(s) in dotnet-eng [ Nearest version: 5.0.0-alpha.1.19618.1 ]
error NU1102:   - Found 0 version(s) in benchmark-dotnet-prerelease
error NU1102:   - Found 0 version(s) in dotnet-tools
error NU1102:   - Found 0 version(s) in dotnet3.1-transport
error NU1102:   - Found 0 version(s) in dotnet5-transport
```
@radical radical changed the title [wasm] Fix perf-pipeline [release/7.0][wasm] Fix perf-pipeline errors Sep 11, 2022
@radical radical marked this pull request as ready for review September 11, 2022 02:34
@radical
Copy link
Member Author

radical commented Sep 11, 2022

Building on dotnet-runtime-perf - 20220910.6.

@radical radical changed the title [release/7.0][wasm] Fix perf-pipeline errors [release/7.0][wasm] Fix broken dotnet-runtime-perf Sep 11, 2022
@jkotas jkotas mentioned this pull request Sep 12, 2022
Closed
@ghost
Copy link

ghost commented Sep 12, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Build SizeOnDisk, and Startup tools for net7.0 instead of net6.0.

It current fails with:

error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.10)
error NU1102:   - Found 2073 version(s) in dotnet6 [ Nearest version: 6.0.2-servicing.1.22101.5 ]
error NU1102:   - Found 1520 version(s) in dotnet7 [ Nearest version: 7.0.0-alpha.1.21417.28 ]
error NU1102:   - Found 1120 version(s) in dotnet5 [ Nearest version: 6.0.0-alpha.1.20420.3 ]
error NU1102:   - Found 76 version(s) in dotnet3.1 [ Nearest version: 3.1.1-servicing.19602.11 ]
error NU1102:   - Found 52 version(s) in dotnet-public [ Nearest version: 7.0.0-preview.1.22076.8 ]
error NU1102:   - Found 1 version(s) in dotnet-eng [ Nearest version: 5.0.0-alpha.1.19618.1 ]
error NU1102:   - Found 0 version(s) in benchmark-dotnet-prerelease
error NU1102:   - Found 0 version(s) in dotnet-tools
error NU1102:   - Found 0 version(s) in dotnet3.1-transport
error NU1102:   - Found 0 version(s) in dotnet5-transport
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono, perf-pipeline
Milestone: -

@carlossanlop
Copy link
Member

@lewing @marek-safar can we get a sign off and an approval, respectively?

LoopedBard3
LoopedBard3 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3
Copy link
Member

Is this also something we should update on the main branch?

@radical
Copy link
Member Author

radical commented Sep 12, 2022

Is this also something we should update on the main branch?

Yep, and there is a PR for that - #75406 .

@carlossanlop
Copy link
Member

SIgned off. CI failure unrelated. Just noticed it is an infra change only, so no approval needed. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit fa4ba1b into dotnet:release/7.0 Sep 12, 2022
@radical radical deleted the fix-perf-7 branch September 12, 2022 18:26
@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

@lewing lewing Awaiting requested review from lewing

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @carlossanlop @LoopedBard3 @jeffschwMSFT