Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0][mono] Fix assertion while adding a new method using Hot Reload #75460

Merged
merged 1 commit into from
Sep 12, 2022
Merged

[release/7.0][mono] Fix assertion while adding a new method using Hot Reload #75460

merged 1 commit into from
Sep 12, 2022

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Sep 12, 2022

Backport of #75432 to release/7.0

Customer Impact

When creating a new method and applying using hot reload it was hitting an assertion on mono runtime.

Testing

Manual and added a unit test

Risk

Low risk, only reordered the variables initialization.

@thaystg thaystg requested a review from lewing September 12, 2022 16:12
@ghost ghost assigned thaystg Sep 12, 2022
@ghost
Copy link

ghost commented Sep 12, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75432 to release/7.0

Customer Impact

When creating a new method and applying using hot reload it was hitting an assertion on mono runtime.

Testing

Manual and added a unit test

Risk

Low risk, only reordered the variables initialization.

Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono
Milestone: -

@steveisok steveisok self-requested a review September 12, 2022 18:36
steveisok
steveisok approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add mine to make it even more official ;-)

@radical
Copy link
Member

radical commented Sep 12, 2022

Some of the wasm/runtime-tests are failing because the version fix from - https://github.com/dotnet/runtime/pull/75397/files#diff-dde71e6c5fa0d364c6b3a7c018b6f1a5435dbc1512757995af9c15f86674deb3R3 is needed.

@radical
Copy link
Member

radical commented Sep 12, 2022

Some of the wasm/runtime-tests are failing because the version fix from - #75397 (files) is needed.

The changes here don't affect runtime-tests, IOW, the failures are unrelated. I will open a separate PR for the fix.

@radical
Copy link
Member

radical commented Sep 12, 2022

Some of the wasm/runtime-tests are failing because the version fix from - #75397 (files) is needed.

The changes here don't affect runtime-tests, IOW, the failures are unrelated. I will open a separate PR for the fix.

#75472

@carlossanlop
Copy link
Member

This PR has collected the 5 sign-off Infinity Stones of the Mono team.
CI failures investigated and determined to be unrelated.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit abaf6f4 into dotnet:release/7.0 Sep 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@lewing lewing lewing approved these changes

@marek-safar marek-safar marek-safar approved these changes

@steveisok steveisok steveisok approved these changes

@lambdageek lambdageek lambdageek approved these changes

Assignees

@thaystg thaystg

Labels
area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thaystg @radical @carlossanlop @lewing @marek-safar @steveisok @lambdageek